-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aws-codedeploy): add auto rollback configuration to server Deployment Group #925
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -48,6 +48,12 @@ | |
"Arn" | ||
] | ||
}, | ||
"AutoRollbackConfiguration": { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Did you specify Also, add a unit test There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Those are actually 2 different tests :) I've specified
Done. |
||
"Enabled": true, | ||
"Events": [ | ||
"DEPLOYMENT_FAILURE" | ||
] | ||
}, | ||
"DeploymentConfigName": { | ||
"Ref": "CustomDeployConfig52EEBC13" | ||
}, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am assuming this requires that alarms are associated with the deployment group. Is there any meaning for this without alarms? Should we validate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point on validation - by default can we set this to false if customers create a deployment group without any cloudWatch alarm and set this true when they create/update deployment with CloudWatch alarms?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea. I had to change the order the PRs have been submitted in to merge the alarms one (#926) before this one, but thankfully that one was approved already.
I've rebased this PR on top of the alarms one, added validation, and changed the default to depend on whether any Alarms were provided.