POC: construct compatibility removal - full #9056
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
July 14, 2020 13:15
- import changes - Logging - Aspects - app.synth() instead of ConstructNode.prepare() - node.validate() instead of ConstructNode.validate() - DependencyGroup instead of ConcreteDependable - Tag.add() instead of applyAspect(new Tag()) - DependableTrait.implement() instead of Dependable.implement()
- Use `node.addValidation()` instead of `validate()`. - node.validate() returns string[]
Remove usage of the `prepare()` hook from across the library.
Add an implicit "App" construct for root stacks
- removal of "construct-compat.ts" - removal of "dependency.ts" - implicit `App` for root `Stack`s - introduce `Aspects.of()` - introduce `Logging.of()` - centralized synthesis: - stage assets during initialization - tree.synthesizeTree() - stack.synthesizeTemplate() - Add `force` synthesis option - awslint changes - decdk changes
added 3 commits
July 14, 2020 16:46
added 13 commits
July 15, 2020 16:00
This reverts commit 69e221a.
…compat-removal-poc
…compat-removal-poc
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
eladb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POC for aws/aws-cdk-rfcs#192
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license