Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(codecov-action): update to codecov/codecov-action@v5. Use OIDC instead of codecov token #33246

Merged
merged 3 commits into from
Jan 31, 2025

Conversation

QuantumNeuralCoder
Copy link
Contributor

Issue # (if applicable)

Closes #
Resolve intermittent failures for codecov-action complaining about CODECOV_TOKEN.
https://github.com/aws/aws-cdk/actions/runs/12987465886/job/36314301605 for #33174

Reason for this change

Resolve intermittent codecov-action failures by upgrading codecov-actions and moving to OIDC instead of codecov token.

Description of changes

Updated codecov.yml

Describe any new or updated permissions being added

Description of how you validated changes

N/A

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Jan 30, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 30, 2025 22:42
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@QuantumNeuralCoder QuantumNeuralCoder changed the title chore(codecov-action) - update to codecov/codecov-action@v5. Use OIDC instead of codecov token feat(codecov-action) - update to codecov/codecov-action@v5. Use OIDC instead of codecov token Jan 31, 2025
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.84%. Comparing base (0895fde) to head (9de56d4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33246   +/-   ##
=======================================
  Coverage   80.84%   80.84%           
=======================================
  Files         232      232           
  Lines       14135    14135           
  Branches     2460     2460           
=======================================
  Hits        11428    11428           
  Misses       2427     2427           
  Partials      280      280           
Flag Coverage Δ
suite.unit 80.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 79.64% <ø> (ø)
packages/aws-cdk-lib/core 82.17% <ø> (ø)

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9de56d4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@QuantumNeuralCoder QuantumNeuralCoder changed the title feat(codecov-action) - update to codecov/codecov-action@v5. Use OIDC instead of codecov token chore(codecov-action) - update to codecov/codecov-action@v5. Use OIDC instead of codecov token Jan 31, 2025
@QuantumNeuralCoder QuantumNeuralCoder added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Jan 31, 2025
@QuantumNeuralCoder
Copy link
Contributor Author

Exemption Request for readme, test and integ

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Jan 31, 2025
@QuantumNeuralCoder QuantumNeuralCoder changed the title chore(codecov-action) - update to codecov/codecov-action@v5. Use OIDC instead of codecov token chore(codecov-action): Update to codecov/codecov-action@v5. Use OIDC instead of codecov token Jan 31, 2025
@QuantumNeuralCoder QuantumNeuralCoder changed the title chore(codecov-action): Update to codecov/codecov-action@v5. Use OIDC instead of codecov token chore(codecov-action): update to codecov/codecov-action@v5. Use OIDC instead of codecov token Jan 31, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 31, 2025 21:06

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Contributor

mergify bot commented Jan 31, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 330a919 into main Jan 31, 2025
53 checks passed
@mergify mergify bot deleted the QuantumNeuralCoder-patch-1 branch January 31, 2025 21:06
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants