Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rds): allow SecondsUntilAutoPause to be set on ServerlessV2ScalingConfiguration of DatabaseCluster. #32709

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

neilferreira
Copy link
Contributor

Issue # (if applicable)

Closes #32563

Reason for this change

Allow SecondsUntilAutoPause to be set on ServerlessV2ScalingConfiguration of DatabaseCluster.

Description of changes

Allows SecondsUntilAutoPause to be set on ServerlessV2ScalingConfiguration of DatabaseCluster.

Describe any new or updated permissions being added

n/a

Description of how you validated changes

Implemented basic tests in the existing test suite.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

`ServerlessV2ScalingConfiguration` of `DatabaseCluster`.
@aws-cdk-automation aws-cdk-automation requested a review from a team January 2, 2025 02:47
@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Jan 2, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.54%. Comparing base (dd34d2e) to head (bac864b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32709   +/-   ##
=======================================
  Coverage   81.54%   81.54%           
=======================================
  Files         226      226           
  Lines       13777    13777           
  Branches     2414     2414           
=======================================
  Hits        11235    11235           
  Misses       2270     2270           
  Partials      272      272           
Flag Coverage Δ
suite.unit 81.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.94% <ø> (ø)
packages/aws-cdk-lib/core 82.17% <ø> (ø)

@neilferreira neilferreira changed the title Allow SecondsUntilAutoPause to be set on ServerlessV2ScalingConfiguration of DatabaseCluster. feat(rds): Allow SecondsUntilAutoPause to be set on ServerlessV2ScalingConfiguration of DatabaseCluster. Jan 2, 2025
@neilferreira neilferreira changed the title feat(rds): Allow SecondsUntilAutoPause to be set on ServerlessV2ScalingConfiguration of DatabaseCluster. feat(rds): allow SecondsUntilAutoPause to be set on ServerlessV2ScalingConfiguration of DatabaseCluster. Jan 2, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 2, 2025 03:38

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: bac864b
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
2 participants