Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ecr-assets): mention CDK_DOCKER environment variable in README #32586

Merged
merged 8 commits into from
Dec 28, 2024

Conversation

ymotongpoo
Copy link
Contributor

@ymotongpoo ymotongpoo commented Dec 19, 2024

Issue # (if applicable)

Closes #32585.

Reason for this change

This change adds description that CDK_DOCKER environment variable is also effective in aws-ecr-assets module like aws-s3-assets.

Description of changes

Just a documentation change. No code change.

Describe any new or updated permissions being added

N/A

Description of how you validated changes

I confirmed the environment variable is effective locally.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Dec 19, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team December 19, 2024 09:04
@github-actions github-actions bot added the p2 label Dec 19, 2024
Copy link
Contributor

@WinterYukky WinterYukky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 19, 2024
@kaizencc kaizencc changed the title chore(ecr-assets): add document about CDK_DOCKER environment variable docs(ecr-assets): mention CDK_DOCKER environment variable in README Dec 19, 2024
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions github-actions bot added the effort/small Small work item – less than a day of effort label Dec 19, 2024
Copy link
Contributor

mergify bot commented Dec 19, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Dec 19, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Dec 19, 2024

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #32586 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (detail: 4 of 6 required status checks are expected.).

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 19, 2024
Copy link
Contributor

mergify bot commented Dec 19, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@ymotongpoo
Copy link
Contributor Author

@Mergifyio requeue

Copy link
Contributor

mergify bot commented Dec 20, 2024

requeue

❌ Command disallowed due to command restrictions in the Mergify configuration.

  • sender-permission >= write

@ymotongpoo
Copy link
Contributor Author

@aws/aws-cdk-owners should I just wait for getting this merged automatically or do I have anything to do here?

@kaizencc
Copy link
Contributor

Sorry :(. Will keep an eye out and get your PR merged

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.69%. Comparing base (1c9103e) to head (1a4979f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32586   +/-   ##
=======================================
  Coverage   80.69%   80.69%           
=======================================
  Files         108      108           
  Lines        7019     7019           
  Branches     1299     1299           
=======================================
  Hits         5664     5664           
  Misses       1175     1175           
  Partials      180      180           
Flag Coverage Δ
suite.unit 80.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.69% <ø> (ø)

Copy link
Contributor

mergify bot commented Dec 27, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1a4979f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Dec 27, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 7f6f94c into aws:main Dec 28, 2024
17 checks passed
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-ecr-assets: there's no description about CDK_DOCKER environment variable
5 participants