-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: print more information in Aspects proptest #32543
Conversation
We weren't printing which Aspects were there at the start of the tree, vs which Aspects were added during the Aspect run. Print that info.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32543 +/- ##
=======================================
Coverage 78.85% 78.85%
=======================================
Files 108 108
Lines 7165 7165
Branches 1319 1319
=======================================
Hits 5650 5650
Misses 1330 1330
Partials 185 185
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it intended for this change to be only added in the unit test file?
Yes! It adds debug printing which will help debug occasional proptest errors. |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Comments on closed issues and PRs are hard for our team to see. |
We weren't printing which Aspects were there at the start of the tree, vs which Aspects were added during the Aspect run.
Print that info.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license