chore(yargs-gen): use lodash.clonedeep instead of structured clone #32537
Conversation
mrgrain
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
added
the
pr/needs-cli-test-run
mrgrain
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
This will make it easier to run the build on node 16. Required adjacent changes: pkglint had a bug that made it fail for packages with a `.` in their name. Instead now allow to pass the json path directly as an array. Make the yargs-gen script in the CLI not prefer ts files, so that it doesn't have to re-compile most of the cli code when running.
mrgrain
force-pushed
the
mrgrain/chore/no-structured-clone
branch
from
166a4f9 to
65060f2
Compare
mrgrain
temporarily deployed
to
test-pipeline
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32537 +/- ##
=======================================
Coverage 78.77% 78.77%
=======================================
Files 108 108
Lines 7163 7163
Branches 1320 1320
=======================================
Hits 5643 5643
Misses 1335 1335
Partials 185 185
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
mrgrain
added
pr-linter/cli-integ-tested
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
This will make it easier to run the build on node 16.
Adjacent changes:
pkglint had a bug that made it fail for packages with a
.in their name. Instead now allow to pass the json path directly as an array.Move inline function extraction completely into config and not part of yargs-gen.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license