-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cli): separate parsing config files from using the config data #32371
Conversation
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32371 +/- ##
==========================================
+ Coverage 78.50% 78.51% +0.01%
==========================================
Files 106 106
Lines 7201 7210 +9
Branches 1321 1322 +1
==========================================
+ Hits 5653 5661 +8
- Misses 1361 1362 +1
Partials 187 187
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
Comments on closed issues and PRs are hard for our team to see. |
Right now we read the configuration files directly to get the region. In the future, we may need to get other configuration from these files.
This change separates two concerns: reading and merging the files on one hand, and using the configuration data, on the other.
If we had this clear separation of concerns before we migrated to SDK v3, it would have reduced the risk for one of the regressions.
Copied from the SDK code itself.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license