Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eks): add L2 constructs to support EKS Hybrid Nodes #32370

Closed
wants to merge 1 commit into from

Conversation

abhay-krishna
Copy link
Member

@abhay-krishna abhay-krishna commented Dec 3, 2024

Issue # (if applicable)

Closes #32362 .

Reason for this change

This change allows users to specify the networking primitives for an EKS Hybrid nodes cluster through L2 constructs.

Description of changes

This PR introduces a new top-level field called remoteNetworkConfig in the Cluster construct, which contains two fields namely remoteNodeNetworks and remotePodNetworks. Together, these allow users to specify the exact CIDRs ranges they want to use for their remote nodes and (optionally) pods. Hybrid nodes requires that none of the node and pod CIDRs overlap with each other so I have also added a validation for that.

Description of how you validated changes

Added unit tests with different testcases involving different remote network configurations.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Dec 3, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team December 3, 2024 09:14
@abhay-krishna abhay-krishna changed the title Add L2 constructs to support EKS Hybrid Nodes WIP: Add L2 constructs to support EKS Hybrid Nodes Dec 3, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@abhay-krishna abhay-krishna changed the title WIP: Add L2 constructs to support EKS Hybrid Nodes WIP: feat(eks): Add L2 constructs to support EKS Hybrid Nodes Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.50%. Comparing base (bf77e51) to head (cdd08ef).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32370   +/-   ##
=======================================
  Coverage   78.50%   78.50%           
=======================================
  Files         106      106           
  Lines        7201     7201           
  Branches     1321     1321           
=======================================
  Hits         5653     5653           
  Misses       1361     1361           
  Partials      187      187           
Flag Coverage Δ
suite.unit 78.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 78.50% <ø> (ø)

@abhay-krishna abhay-krishna changed the title WIP: feat(eks): Add L2 constructs to support EKS Hybrid Nodes feat(eks): Add L2 constructs to support EKS Hybrid Nodes Dec 3, 2024
@abhay-krishna abhay-krishna changed the title feat(eks): Add L2 constructs to support EKS Hybrid Nodes feat(eks): add L2 constructs to support EKS Hybrid Nodes Dec 3, 2024
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Features must contain a change to a README file.
❌ Features must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

Copy link

github-actions bot commented Dec 5, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eks: Add L2 constructs for EKS Hybrid Nodes support
2 participants