-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eks): add L2 constructs to support EKS Hybrid Nodes #32370
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
db03c52
to
cdd08ef
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32370 +/- ##
=======================================
Coverage 78.50% 78.50%
=======================================
Files 106 106
Lines 7201 7201
Branches 1321 1321
=======================================
Hits 5653 5653
Misses 1361 1361
Partials 187 187
Flags with carried forward coverage won't be shown. Click here to find out more.
|
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #32362 .
Reason for this change
This change allows users to specify the networking primitives for an EKS Hybrid nodes cluster through L2 constructs.
Description of changes
This PR introduces a new top-level field called
remoteNetworkConfig
in theCluster
construct, which contains two fields namelyremoteNodeNetworks
andremotePodNetworks
. Together, these allow users to specify the exact CIDRs ranges they want to use for their remote nodes and (optionally) pods. Hybrid nodes requires that none of the node and pod CIDRs overlap with each other so I have also added a validation for that.Description of how you validated changes
Added unit tests with different testcases involving different remote network configurations.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license