fix(cli): remove deprecated validation around ARM build image types

[PeterEckIII]

Issue # (if applicable)

Closes #30869 .

Reason for this change

Now that ARM images support all compute types (not just ComputeType.SMALL and ComputeType.LARGE) the validate function is outdated.

Description of changes

Removed the validate method from aws-cdk/packages/aws-cdk-lib/aws-codebuild/lib/linux-arm-build-image.ts and the accompanying comment

Description of how you validated changes

Updated tests for aws-codebuild to reflect the accepted types.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: b820a2c
• Result: FAILED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[scanlonp]

This looks like a good start, but still needs a couple things:

1. Do we call the validate function anywhere? We should clean up that invocation.
2. There are a lot of changes to these test files that are spacing or changing ' to ". Let's not change the formatting, and only remove the impacted tests.
3. This would be a great change to add in an integ test for some of the other instance sizes. They are in packages/@aws-cdk-testing/framework-integ. If there are codebuilds with ARM images, lets add one in the same test file where the compute type was previously disallowed. That way we have verification that these sizes are indeed supported!

[PeterEckIII]

@scanlonp , thanks for the feedback here. Working on this today and had a few questions:

1. These are the files that also mention that function.

• https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-codebuild/lib/linux-gpu-build-image.ts#L144-L153 does this need to be removed as well?
• https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-codebuild/lib/project.ts#L1727 this would presumably need to be removed as well so LinuxArmBuildImage can properly implement IBuildImage

Other that those two files I didn't see other mentions of this specific implementation or calling of validate (that is, one that takes a buildEnvironment as its first and only parameter).

2. That must be something my editor is doing. I'll take a look and amend the commit
3. Sounds good, I'll get to work on that as well
   Thanks!

[scanlonp]

@PeterEckIII, I may have been wrong about removing the validate function. It does need to be present and implemented to correctly implement IBuildImage. It should not be removed since it's valuable on every image type. Looking at the other validate functions, I am sure there are configurations that are not allowed for ARM images that do not relate to the size of the compute type!

Also, would you mind amending the title of the PR? Thankfully we are fixing codebuild, not the cli :)

[PeterEckIII]

@scanlonp, oh no! 😅 Ok, in that case I may withdraw the PR altogether and just start fresh if that's ok.

[aws-cdk-automation]

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

[aws-cdk-automation]

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

[aws-cdk-automation]

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.