-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ecs): add GPU support in container definition #3044
Merged
mergify
merged 16 commits into
aws:master
from
mattmcclean:mattmcclean/ecs-gpu-task-def
Aug 22, 2019
Merged
feat(ecs): add GPU support in container definition #3044
mergify
merged 16 commits into
aws:master
from
mattmcclean:mattmcclean/ecs-gpu-task-def
Aug 22, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from eladb
June 24, 2019 20:11
mattmcclean
changed the title
feat(ecs) add GPU support in container definition
feat(ecs): add GPU support in container definition
Jun 24, 2019
SoManyHs
previously approved these changes
Aug 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry this took awhile to get to. LGTM, modulo updating base branch!
Pull Request Checklist
|
1 similar comment
Pull Request Checklist
|
SoManyHs
approved these changes
Aug 22, 2019
Thank you for contributing! Your pull request is now being automatically merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new property called
gpuCount
to the ContainerDefinition of a Task Definition resource adding the number of GPUs assigned to the container.Fixes #2729
Please read the contribution guidelines and follow the pull-request checklist.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license