-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aws-apigateway): expand RestApi support to models, parameters and validators #2960
Merged
eladb
merged 17 commits into
aws:master
from
julienlepine:julienlepine/apigw-request-model
Jun 27, 2019
Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
53eb1e7
feat(aws-apigateway): expand RestApi support to models, parameters an…
julienlepine 221fc0d
feat(aws-apigateway): expand RestApi support to models, parameters an…
julienlepine 32cdcc1
Merge branch 'julienlepine/apigw-request-model' of github.com:julienl…
julienlepine 9f68b9c
Merge from upstream/master, and update from breaking changes.
julienlepine c4b1ec7
Merge with awslabs/aws-cdk master
julienlepine 52a10c4
Merge branch 'master' into julienlepine/apigw-request-model
20a6367
Merge and address PR Review comments.
julienlepine 373a9ba
Merge back from remote
julienlepine c3e6267
Merge branch 'master' into julienlepine/apigw-request-model
julienlepine c5603b8
Move back to modelId
julienlepine a7264b6
Merge branch 'master' into julienlepine/apigw-request-model
julienlepine da87366
Change modelName to modelId in ERROR_MODEL and EMPTY_MODEL
julienlepine 31138b7
re-implement ErrorModel and EmptyModel classes.
julienlepine 7a8ecbb
Merge branch 'master' into julienlepine/apigw-request-model
julienlepine a036082
@deprecated to old entries
julienlepine ff1cf4a
Merge branch 'master' into julienlepine/apigw-request-model
julienlepine 3d8e7fc
Merge branch 'master' into julienlepine/apigw-request-model
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Move back to modelId
Use PhysicalName constructs
- Loading branch information
commit c5603b89dde1c48bed8901d2ebe5aaeb0463ea72
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be “this.physicalName”
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done for Model.ts, for RequestValidator the name is actually kind of useless per se, name is not a property of the CfnRequestValidator, and it's really an Id.