Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(stepfunctions-tasks): add ExecutionParameters to AthenaStartQueryExecution #27287

Merged
merged 9 commits into from
Oct 11, 2023
Merged

feat(stepfunctions-tasks): add ExecutionParameters to AthenaStartQueryExecution #27287

merged 9 commits into from
Oct 11, 2023

Conversation

nakedible-p
Copy link
Contributor

Add missing ExecutionParameters option to AthenaStartQueryExecution step.

Closes #27286.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team September 25, 2023 20:59
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK feature-request A feature should be added or improved. p2 labels Sep 25, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Sep 25, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@nakedible-p nakedible-p changed the title Add ExecutionParameters to AthenaStartQueryExecution feat(stepfunctions-tasks): Add ExecutionParameters to AthenaStartQueryExecution Sep 25, 2023
@nakedible-p nakedible-p force-pushed the patch-1 branch 2 times, most recently from a970f7c to 0d9d2e9 Compare September 25, 2023 21:22
@nakedible-p
Copy link
Contributor Author

Need to manage to regenerate the integration test files and this should be good to go...

@aws-cdk-automation aws-cdk-automation dismissed their stale review September 28, 2023 09:50

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 28, 2023
lpizzinidev
lpizzinidev suggested changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution 💪
Left you some notes on a couple of minor fixes and a missing validation.

packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/athena/start-query-execution.ts Show resolved Hide resolved
packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/athena/start-query-execution.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/athena/start-query-execution.ts Show resolved Hide resolved
@nakedible-p
Copy link
Contributor Author

@lpizzinidev Thank you for the review!

@github-actions github-actions bot mentioned this pull request Oct 1, 2023
Closed
lpizzinidev
lpizzinidev suggested changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for applying the changes!
A couple of adjustments are needed on validation and some missing unit tests.

packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/athena/start-query-execution.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/athena/start-query-execution.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/athena/start-query-execution.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-stepfunctions-tasks/test/athena/start-query-execution.test.ts Outdated Show resolved Hide resolved
@nakedible-p nakedible-p force-pushed the patch-1 branch 3 times, most recently from fc9f3b1 to 3cc79b7 Compare October 4, 2023 13:04
lpizzinidev
lpizzinidev suggested changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes.
A couple of unit tests are needed to complete validation coverage.

packages/aws-cdk-lib/aws-stepfunctions-tasks/test/athena/start-query-execution.test.ts
@@ -224,4 +224,138 @@ describe('Start Query Execution', () => {
}),
});
});

test('execution parameters succeeds', () => {
Copy link
Contributor

@lpizzinidev lpizzinidev Oct 4, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing test cases:

  1. executionParameters: []
  2. executionParameters: ['']

@TheRealAmazonKendra TheRealAmazonKendra changed the title feat(stepfunctions-tasks): Add ExecutionParameters to AthenaStartQueryExecution feat(stepfunctions-tasks): add ExecutionParameters to AthenaStartQueryExecution Oct 4, 2023
@github-actions github-actions bot added the effort/small Small work item – less than a day of effort label Oct 4, 2023
nakedible-p and others added 6 commits October 4, 2023 21:13
@nakedible-p
Add ExecutionParameters to AthenaStartQueryExecution
90727e4 
Add missing `ExecutionParameters` option to `AthenaStartQueryExecution` step.
@nakedible-p
Add validation function for executionParameters
de78f8b
@nakedible-p
Add a bit more detail to documentation
ddd8057
@nakedible-p
Remove superfluous question mark
3738fe4
@nakedible-p @lpizzinidev
Update packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/athena/start-…
ebd16bb 
…query-execution.ts

Co-authored-by: Luca Pizzini <[email protected]>

Update packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/athena/start-query-execution.ts

Co-authored-by: Luca Pizzini <[email protected]>

Update packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/athena/start-query-execution.ts

Co-authored-by: Luca Pizzini <[email protected]>
@nakedible-p
Add more testcases
0e49ff6
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 5, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 5, 2023
vinayak-kukreja
vinayak-kukreja previously approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@vinayak-kukreja vinayak-kukreja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thank you for your contribution.

And also, thank you @lpizzinidev for reviewing the PR.

@mergify
Copy link
Contributor

mergify bot commented Oct 10, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 10, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 10, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed vinayak-kukreja’s stale review October 11, 2023 00:04

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 158c3b2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 11, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 11, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 3fc86ca into aws:main Oct 11, 2023
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 11, 2023
@nakedible-p nakedible-p deleted the patch-1 branch October 11, 2023 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrgrain mrgrain mrgrain left review comments

@lpizzinidev lpizzinidev lpizzinidev approved these changes

@vinayak-kukreja vinayak-kukreja vinayak-kukreja approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws-stepfunctions-tasks: AthenaStartQueryExecution is missing ExecutionParameters
5 participants
@nakedible-p @aws-cdk-automation @mrgrain @lpizzinidev @vinayak-kukreja