Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(neptune): add engine version 1.1.1.0 #21079

Merged
merged 1 commit into from
Jul 11, 2022
Merged

feat(neptune): add engine version 1.1.1.0 #21079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/@aws-cdk/aws-neptune/lib/cluster.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,10 @@ export class EngineVersion {
* Neptune engine version 1.1.0.0
*/
public static readonly V1_1_0_0 = new EngineVersion('1.1.0.0');
/**
* Neptune engine version 1.1.1.0
*/
public static readonly V1_1_1_0 = new EngineVersion('1.1.1.0');

/**
* Constructor for specifying a custom engine version
Expand Down
23 changes: 23 additions & 0 deletions packages/@aws-cdk/aws-neptune/test/cluster.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,29 @@ describe('DatabaseCluster', () => {
});
});

test.each([
['1.1.1.0', EngineVersion.V1_1_1_0],
])('can create a cluster for engine version %s', (expected, version) => {
// GIVEN
const stack = testStack();
const vpc = new ec2.Vpc(stack, 'VPC');

// WHEN
new DatabaseCluster(stack, 'Database', {
vpc,
instanceType: InstanceType.R5_LARGE,
engineVersion: version,
});

// THEN
Template.fromStack(stack).hasResourceProperties('AWS::Neptune::DBCluster', {
EngineVersion: expected,
DBSubnetGroupName: { Ref: 'DatabaseSubnets3C9252C9' },
VpcSecurityGroupIds: [{ 'Fn::GetAtt': ['DatabaseSecurityGroup5C91FDCB', 'GroupId'] }],
});
});


test('can create a cluster with imported vpc and security group', () => {
// GIVEN
const stack = testStack();
Expand Down