Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(redshift): add elasticIp property to cluster #19192

Closed
wants to merge 5 commits into from
Closed

feat(redshift): add elasticIp property to cluster #19192

wants to merge 5 commits into from

Conversation

rnsaway
Copy link

@rnsaway rnsaway commented Feb 28, 2022

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

MOTIVATION: to add ability to specify elasticIp prop.

Fixes issue #19191

@gitpod-io
Copy link

gitpod-io bot commented Feb 28, 2022

@github-actions github-actions bot added the @aws-cdk/aws-redshift Related to Amazon Redshift label Feb 28, 2022
@mergify
Copy link
Contributor

mergify bot commented Feb 28, 2022

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@rnsaway rnsaway changed the title fix(aws-redshift):adding elasticIp prop fix(aws-redshift): Fix for adding elasticIp prop Feb 28, 2022
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: d6a9199
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@rix0rrr rix0rrr added feature-request A feature should be added or improved. p1 and removed p1 feature-request A feature should be added or improved. @aws-cdk/aws-redshift Related to Amazon Redshift labels Mar 4, 2022
kaizencc
kaizencc requested changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rnsaway, this needs a test to go along with the change

@kaizencc kaizencc assigned kaizencc and unassigned skinny85 Mar 15, 2022
@kaizencc kaizencc changed the title fix(aws-redshift): Fix for adding elasticIp prop feat(redshift): add elasticIp property to cluster Mar 15, 2022
@kaizencc kaizencc added the pr-linter/exempt-readme The PR linter will not require README changes label Mar 15, 2022
@github-actions github-actions bot added the @aws-cdk/aws-redshift Related to Amazon Redshift label Mar 15, 2022
@aws-cdk-automation
Copy link
Collaborator

This PR has been in CHANGES REQUESTED for 21 days, and looks abandoned. It will be closed in 10 days if no further commits are pushed to it.

@github-actions
Copy link

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@github-actions github-actions bot added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Apr 20, 2022
@github-actions github-actions bot closed this Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaizencc kaizencc kaizencc requested changes

Assignees

@skinny85 skinny85

@kaizencc kaizencc

Labels
@aws-cdk/aws-redshift Related to Amazon Redshift closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. feature-request A feature should be added or improved. p1 pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rnsaway @aws-cdk-automation @kaizencc @skinny85 @rix0rrr