-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make examples compile #18020
Merged
Merged
chore: make examples compile #18020
Changes from 6 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
3530885
chore(custom-resources): make examples compile
kaizencc 14d9ac8
chore(s3-assets): make examples compile
kaizencc 409c3fa
chore(backup): make examples compile
kaizencc 3f73a4d
chore(s3-deployment): make examples compile
kaizencc 48ee3b3
chore(s3-notifications): make examples compile
kaizencc 18cd1ef
fix backup readme
kaizencc e741b87
chore(cloudtrail): make examples compile
kaizencc a0150d7
chore(config): make examples compile
kaizencc dcc7fcb
Merge branch 'master' into compile-modules
kaizencc a0bb231
fix outstanding s3-assets example
kaizencc 8201396
Merge branch 'master' into compile-modules
kaizencc e4c84ce
Update README.md
rix0rrr e5bd4c9
fix example
kaizencc 2399bb5
Merge branch 'master' into compile-modules
mergify[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
packages/@aws-cdk/aws-s3-assets/rosetta/default.ts-fixture
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
// Fixture with packages imported, but nothing else | ||
import { Construct } from 'constructs'; | ||
import { BundlingOptions, BundlingOutput, DockerImage, Stack } from '@aws-cdk/core'; | ||
import * as assets from '@aws-cdk/aws-s3-assets'; | ||
|
||
class Fixture extends Stack { | ||
constructor(scope: Construct, id: string) { | ||
super(scope, id); | ||
|
||
/// here | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
packages/@aws-cdk/aws-s3-deployment/rosetta/default.ts-fixture
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
// Fixture with packages imported, but nothing else | ||
import { Duration, Stack } from '@aws-cdk/core'; | ||
import { Construct } from 'constructs'; | ||
import * as s3deploy from '@aws-cdk/aws-s3-deployment'; | ||
import * as s3 from '@aws-cdk/aws-s3'; | ||
import * as ec2 from'@aws-cdk/aws-ec2'; | ||
import * as path from 'path'; | ||
|
||
class Fixture extends Stack { | ||
constructor(scope: Construct, id: string) { | ||
super(scope, id); | ||
|
||
/// here | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
packages/@aws-cdk/aws-s3-notifications/rosetta/default.ts-fixture
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
// Fixture with packages imported, but nothing else | ||
import { Stack } from '@aws-cdk/core'; | ||
import { Construct } from 'constructs'; | ||
import * as s3n from '@aws-cdk/aws-s3-notifications'; | ||
import * as s3 from '@aws-cdk/aws-s3'; | ||
import * as path from 'path'; | ||
|
||
class Fixture extends Stack { | ||
constructor(scope: Construct, id: string) { | ||
super(scope, id); | ||
|
||
/// here | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this compile in Python too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It passes
rosetta:extract --compile
so it should. However, this entire PR is waiting on a fix inbackup
I'm going to make very soon (which is why build is failing).edit: nevermind, no fix necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work actually. If Rosetta doesn't flag this, that's a bug in Rosetta.
You need to declare an explicit class that implements the right interface.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaizen3031593 for context: #17928
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rip rosetta. I can investigate what is going on in
rosetta
later. In fact, I looked back at what I did inlambda-go
which also included a bundling function. I recall thatrosetta:extract --compile
did not pass there and what I did was end up making that example atext
snippet and say that the snippet is only available in TypeScript.Which I guess is bad for the Python folks because I'm basically saying, sorry this doesn't work in Python.
That seems to be what #17928 tried and it did not work.