Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lambda-go): fix integ test #17365

Merged
merged 3 commits into from
Nov 5, 2021
Merged

chore(lambda-go): fix integ test #17365

merged 3 commits into from
Nov 5, 2021

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Nov 5, 2021

The test was still using the old lambci image and this makes the integ test fail
apparently. This currently blocks the build of the repo.

Adapted Dockerfile now that go is not installed in /go anymore.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

The test was still using the old `lambci` image.

Adapted Dockerfile now that go is not installed in `/go` anymore.
@gitpod-io
Copy link

gitpod-io bot commented Nov 5, 2021

@mergify
Copy link
Contributor

mergify bot commented Nov 5, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 87d7c6c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 96a8160 into aws:master Nov 5, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 5, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@jogold jogold deleted the fix-go-integ branch November 5, 2021 23:41
iliapolo pushed a commit that referenced this pull request Nov 7, 2021
The test was still using the old `lambci` image and this makes the integ test fail
apparently. **This currently blocks the build of the repo**.

Adapted Dockerfile now that go is not installed in `/go` anymore.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
The test was still using the old `lambci` image and this makes the integ test fail
apparently. **This currently blocks the build of the repo**.

Adapted Dockerfile now that go is not installed in `/go` anymore.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants