fix(ec2): functions addIngressRule and addEgressRule detect unresolved tokens as duplicates #17221
Conversation
|
|
github-actions
bot
added
the
@aws-cdk/aws-ec2
|
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
peterwoodworth
changed the title
peterwoodworth
changed the title
| } else { | ||
| return peer.uniqueId; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
This giant comment block here is really useful. Would be a shame to lose it and/or its context. Can you reunite it back with its friend, the determineRuleScope method? 🥺
| } | ||
|
|
||
| private renderPeer(peer: IPeer) { | ||
| if (Token.isUnresolved(peer.uniqueId)) { |
There was a problem hiding this comment.
A quick comment here explaining the why of this would be useful for future maintainers.
There was a problem hiding this comment.
added right below line 193
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…d tokens as duplicates (aws#17221) fixes aws#17201 The issue is when the same security group uses these functions, so I added a private counter to `SecurityGroupBase`. However, to modify this private counter, `determineRuleScope` and `renderPeer` need to be member functions. These originally weren't member functions for a reason, and that's because `SecurityGroup` also uses these functions. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
fixes #17201
The issue is when the same security group uses these functions, so I added a private counter to
SecurityGroupBase. However, to modify this private counter,determineRuleScopeandrenderPeerneed to be member functions. These originally weren't member functions for a reason, and that's becauseSecurityGroupalso uses these functions.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license