Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): yarn-cling does not work under Node 15 #13391

Merged
merged 3 commits into from
Mar 4, 2021

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Mar 4, 2021

Some tricks we are using to locate packages on disk don't work
anymore under newer Node versions. Switch strategies.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Some tricks we are using to locate packages on disk don't work
anymore under newer Node versions. Switch strategies.
@rix0rrr rix0rrr requested a review from a team March 4, 2021 11:03
@rix0rrr rix0rrr self-assigned this Mar 4, 2021
@gitpod-io
Copy link

gitpod-io bot commented Mar 4, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 4, 2021
@mergify
Copy link
Contributor

mergify bot commented Mar 4, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: a9c1f37
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 4, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 9331657 into master Mar 4, 2021
@mergify mergify bot deleted the huijbers/cling-node15 branch March 4, 2021 14:34
cornerwings pushed a commit to cornerwings/aws-cdk that referenced this pull request Mar 8, 2021
Some tricks we are using to locate packages on disk don't work
anymore under newer Node versions. Switch strategies.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
rix0rrr added a commit that referenced this pull request Mar 9, 2021
Some tricks we are using to locate packages on disk don't work
anymore under newer Node versions. Switch strategies.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants