fix(eks): KubernetesPatch and FargateCluster creates a circular dependency and breaks deployment

[iliapolo]

In version 1.62.0 we introduced the ability to run kubectl commands on imported clusters. (See #9802).

Part of this change included some refactoring with regards to how we use and create the KubectlProvider.
Looks like we didn't consistently apply the same logic across all constructs that use it.

Case in point:

aws-cdk/packages/@aws-cdk/aws-eks/lib/k8s-manifest.ts

Line 58 in e349004

const provider = KubectlProvider.getOrCreate(this, props.cluster);

Notice that here we use this as the scope to the getOrCreate call. Same goes for:

aws-cdk/packages/@aws-cdk/aws-eks/lib/k8s-object-value.ts

Line 64 in e349004

const provider = KubectlProvider.getOrCreate(this, props.cluster);

However, KubernetesPatch use scope instead.

aws-cdk/packages/@aws-cdk/aws-eks/lib/k8s-patch.ts

Line 74 in e349004

const provider = KubectlProvider.getOrCreate(scope, props.cluster);

This means that the entire scope of the KubernetesPatch now depends, among others, on the kubectlBarrier.
The scope will usually be either the cluster itself (when using FargateCluster), or the entire stack (when using new KubernetesPatch). In any case, the scope will most likely contain the cluster VPC.

This creates the following dependency cycle: Cluster => ClusterVpc => KubectlBarrier => Cluster.

The fix aligns the KubernetesPatch behavior to all other kubectl constructs and uses this as the scope, which will only add dependency on the barrier to the custom resource representing the patch.

Fixes #10528
Fixes #10537

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[mergify]

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

[eladb]

Oops

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
• Commit ID: 7cf6b5d
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).