Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cognito] Import existing user pool domain #9988

Closed
2 tasks
jarikujansuu opened this issue Aug 26, 2020 · 1 comment · Fixed by #10550
Closed
2 tasks

[cognito] Import existing user pool domain #9988

jarikujansuu opened this issue Aug 26, 2020 · 1 comment · Fixed by #10550
Assignees
@nija-at
Labels
@aws-cdk/aws-cognito Related to Amazon Cognito effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md in-progress This issue is being actively worked on. p1

Comments

@jarikujansuu
Copy link

There doesn't seem to be way to import existing Cognito user pool domain, so when AuthenticateCognitoActionProps needs IUserPoolDomain it must have been created in CDK (and in that CDK app)

IUserPool and IUserPoolClient can be imported.

Code seems to just copy arns, ids and name from resources so requiring instances of IResource is unnecessary.

Use Case

Need to add listener authentication action for Cognito not created in this CDK project.

Proposed Solution

Change AuthenticateCognitoActionPropsso that user pool, client and domain are interfaces that can be passed manually (not extending IResource).

Or Add static method UserPoolDomain.fromDomainName(domainName: string): IUserPoolDomain so importing user pool domain would be possible.

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@jarikujansuu jarikujansuu added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 26, 2020
@NGL321 NGL321 added the @aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 label Aug 31, 2020
@njlynch njlynch added the @aws-cdk/aws-cognito Related to Amazon Cognito label Sep 1, 2020
@njlynch
Copy link
Contributor

njlynch commented Sep 1, 2020

It seems like adding the import for IUserPoolDomain makes the most sense here.

@nija-at nija-at changed the title [aws-elasticloadbalancingv2-actions] Ability to create Cognito auth action without importing CognitoUserPoolDomain (which is not possible) [cognito] Import existing user pool domain Sep 1, 2020
@nija-at nija-at added effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md p1 and removed @aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 needs-triage This issue or PR still needs to be triaged. labels Sep 1, 2020
@ayush987goyal ayush987goyal mentioned this issue Sep 26, 2020
Merged
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Sep 29, 2020
@mergify mergify bot closed this as completed in #10550 Sep 30, 2020
mergify bot pushed a commit that referenced this issue Sep 30, 2020
@ayush987goyal
feat(cognito): import existing user pool domain (#10550)
37e2c35 
Add fromDomainName import helper to UserPoolDomain construct

closes #9988 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nija-at nija-at

Labels
@aws-cdk/aws-cognito Related to Amazon Cognito effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md in-progress This issue is being actively worked on. p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cognito): import existing user pool domain
5 participants
@jarikujansuu @njlynch @NGL321 @nija-at @SomayaB