Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-synthetics: NodeJS puppeteer Runtime Versions 5.2 & 6.2 & Python Selenium 2.1 #29135

Closed
2 tasks
alaa-nassef opened this issue Feb 16, 2024 · 4 comments · Fixed by #29132
Closed
2 tasks

aws-synthetics: NodeJS puppeteer Runtime Versions 5.2 & 6.2 & Python Selenium 2.1 #29135

alaa-nassef opened this issue Feb 16, 2024 · 4 comments · Fixed by #29132
Labels
@aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1

Comments

@alaa-nassef
Copy link

Describe the feature

On February 6, AWS announced the release of NodeJS puppeteer runtimes 6.2 & 5.2, and python selenium runtime 2.1, and announced that all non-deprecated older versions will be deprecated on March 8th. Today, we got an email from AWS saying that new lambda runtimes will be deployed on March 19th and that the changes will not be backwards compatible with current puppeteer versions so we have to upgrade our runtimes
Screenshot 2024-02-16 at 1 53 45 PM

Those versions do not exist in the latest CDK version, so we need them to be added so that we can update our runtimes, test and deploy to production before the cutoff time

Use Case

AWS will upgrade the lambda runtimes to a non-compatible version with the current puppeteer runtimes, which will break our synthetic canaries.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.128

Environment details (OS name and version, etc.)

MacOS 14
@alaa-nassef alaa-nassef added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 16, 2024
@github-actions github-actions bot added the @aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics label Feb 16, 2024
@npvisual
Copy link

FYI, there's a PR created but doesn't seem to be prioritized yet.
#29132

@wilhen01 wilhen01 mentioned this issue Feb 16, 2024
Merged
1 task
@pahud
Copy link
Contributor

pahud commented Feb 16, 2024

https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-synthetics/lib/runtime.ts

Yeah, I'll bump this to p1.

@pahud pahud added p1 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Feb 16, 2024
@mergify mergify bot closed this as completed in #29132 Feb 16, 2024
mergify bot pushed a commit that referenced this issue Feb 16, 2024
@wilhen01
feat(synthetics): latest canary runtimes for NodeJS, Python (#29132)
3c122a4 
Closes #29135

### Reason for this change

Surface latest runtime versions in CDK. Older runtimes are being deprecated March 19, 2024

> To ensure uninterrupted canary runs and continued monitoring, AWS recommends customers to update their canaries to the latest Synthetics Runtimes versions: syn-nodejs-puppeteer-6.2 or higher for NodeJS-18, syn-nodejs-puppeteer-5.2 or higher for NodeJS-16, and syn-python-selenium-2.1 or higher for Python [2]. Canaries updated with latest Synthetics runtimes will continue running without interruption and receive future Lambda security updates.

### Description of changes

- feat(synthetics): add 5.2, 6.1, 6.2 nodejs runtimes, deprecate 3.x runtimes
- feat(synthetics): add syn-python-selenium-2.1 runtime
- test(synthetics): update integration tests to cover latest runtimes

### Description of how you validated changes

Attempted to run integration tests, but I don't have appropriate account setup

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

GavinZZ pushed a commit that referenced this issue Feb 22, 2024
@wilhen01 @GavinZZ
feat(synthetics): latest canary runtimes for NodeJS, Python (#29132)
efa9cf0 
Closes #29135

### Reason for this change

Surface latest runtime versions in CDK. Older runtimes are being deprecated March 19, 2024

> To ensure uninterrupted canary runs and continued monitoring, AWS recommends customers to update their canaries to the latest Synthetics Runtimes versions: syn-nodejs-puppeteer-6.2 or higher for NodeJS-18, syn-nodejs-puppeteer-5.2 or higher for NodeJS-16, and syn-python-selenium-2.1 or higher for Python [2]. Canaries updated with latest Synthetics runtimes will continue running without interruption and receive future Lambda security updates.

### Description of changes

- feat(synthetics): add 5.2, 6.1, 6.2 nodejs runtimes, deprecate 3.x runtimes
- feat(synthetics): add syn-python-selenium-2.1 runtime
- test(synthetics): update integration tests to cover latest runtimes

### Description of how you validated changes

Attempted to run integration tests, but I don't have appropriate account setup

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions github-actions bot mentioned this issue Mar 1, 2024
Closed
@npvisual
Copy link

npvisual commented Apr 2, 2024 •
edited
Loading

@pahud : we're having the same issue again, this time with SYNTHETICS_PYTHON_SELENIUM_2_1 being deprecated by April 15, 2024.
Would it be possible that those deprecations could be made while taking into account the AWS-provided dependencies (i.e. CDK) ? 15 days is a little tight.
But from a communication standpoint it probably creates issues for customers since the new synthetics versions are not available when those announcements come out.
Thanks !

@npvisual npvisual mentioned this issue Apr 4, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(synthetics): latest canary runtimes for NodeJS, Python
3 participants
@pahud @npvisual @alaa-nassef