aws-log: [Minor improvement] add newline between each statement in CloudWatch Log Saved Query #22422
Labels
@aws-cdk/aws-cloudwatch
Related to Amazon CloudWatch
effort/small
Small work item – less than a day of effort
feature-request
A feature should be added or improved.
p2
Comments
khaing211
added
feature-request
|
I'm not sure I'm following what the use case here is... Can you explain some more? |
indrora
added
p2
effort/small
|
We use this construct to save cloud watch query with place holder. Then, we
go to aws console to execute the query by replace the placeholder with real
value. For example, all logs related to userId X (x = real Id).
Now, when we go to aws console, the code editor shows a single (long) line.
It would be nicer if line breaks to multiple lines. Make sense?
On Tue, Nov 15, 2022 at 4:20 PM Morgan Gangwere ***@***.***> wrote:
I'm not sure I'm following what the use case here is... Can you explain
some more?
—
Reply to this email directly, view it on GitHub
<#22422 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFJBQMK7TDY2BPZTJMSV33WIQSFFANCNFSM6AAAAAAQ72NHNM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Khai Nguyen
|
jerry-shao
added a commit
to jerry-shao/aws-cdk
that referenced
this issue
Nov 25, 2022
jerry-shao
added a commit
to jerry-shao/aws-cdk
that referenced
this issue
Nov 25, 2022
|
Hi @madeline-k , I have raised a PR to improve the readability of Logs Insights Query Definition for this issue: #23094 Thanks! |
mergify bot
pushed a commit
that referenced
this issue
Nov 26, 2022
…#23094) fix(logs): Adding line break for CloudWatch Logs Insights Query Definition (#22422) Verified in AWS Console with integration test, we can see query in multiple lines instead of a single line. <img width="1159" alt="image" src="https://user-images.githubusercontent.com/7830699/204059301-afd0adb7-b24e-4588-a0aa-58fd0cdbbfd8.png"> ---- ### All Submissions: * [✅] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [❌] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [✅] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [✅] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the feature
Could someone add newline between each statement in CloudWatch Log Saved Query?
https://github.com/aws/aws-cdk/blob/v2.45.0/packages/@aws-cdk/aws-logs/lib/query-definition.ts#L105
This format makes this easy for someone to use because the query fits in the AWS Console code editor screen.
Use Case
I'm always frustrated when I have to scroll horizontally, in the code editor on CloudWatch Log Insight Query, to find my placeholder in the Saved Query.
Proposed Solution
No response
Other Information
No response
Acknowledgements
CDK version used
2.x
Environment details (OS name and version, etc.)
NA
The text was updated successfully, but these errors were encountered: