-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IAM: addCondition
overwrites previous conditions
#20158
Comments
Phew, this headline stressed me out when I saw it, but I'm glad it has nothing to do with merging.
We don't recommend using the addXyz function anymore, really. You should try to create the Statement fully-formed |
Multiple calls to `addCondition` aren't as smart as one might want. Clarify that they aren't. Fixes #20158.
addCondition
overwrites previous conditions
Is it intended? Because the semantics is a disjunction instead of "adding" (conjunction) a condition? |
Multiple calls to `addCondition` aren't as smart as one might want. Clarify that they aren't. Fixes #20158. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
Multiple calls to `addCondition` aren't as smart as one might want. Clarify that they aren't. Fixes aws#20158. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Describe the bug
Looking at #19114 the code willThe following code will forget conditions when the only difference is in the value tested, example:will forget the first condition, generating:
instead of
Expected Behavior
Not forget conditions
Current Behavior
Forget conditions
Reproduction Steps
Possible Solution
No response
Additional Information/Context
No response
CDK CLI Version
1.124
Framework Version
No response
Node.js Version
17.4
OS
macos
Language
Typescript
Language Version
No response
Other information
No response
The text was updated successfully, but these errors were encountered: