-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(aws_rds): DatabaseCluster s3ExportBuckets fails with Aurora MySQL 3 #19735
Comments
Hey @vkemthur-luna, thanks for opening the issue. I have one follow-up question though. Right now, for versions of MySQL below 8.0, the parameter names for import/export are different ( However, it seems like you're implying that, for MySQL 8.0, the parameter needs to be the same for both import and export ( Can you confirm that is the case? Because right now, for all Clusters, the Roles we generate for import and export are different (code here, you can see the Thanks, |
Only
So probably need to combine role for engine 8.0 and need to set parameter once As of now this path is adding a parameter not supported on 8.0 As a workaround, looks like I can create a custom role with s3 read/write policy and then set this in |
In the newest version of the MySQL 8.0 Aurora engine, the S3 import and export Roles need to be combined, which is the first time this is needed for a Cluster (previously, only Instances combined those two Roles). Introduce this concept as a first-class property of Cluster engine, `false` by default, and make it `true` in MySQL version 8.0. Fixes aws#19735
Thanks for the explanation @vkemthur-luna! Prepared a fix here: #19775. |
In the newest version of the MySQL 8.0 Aurora engine, the S3 import and export Roles need to be combined, which is the first time this is needed for a Cluster (previously, only Instances combined these two Roles). Introduce this concept as a first-class property of a Cluster Engine, making it `false` by default, and make it `true` in MySQL version 8.0. Fixes #19735 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [x] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
In the newest version of the MySQL 8.0 Aurora engine, the S3 import and export Roles need to be combined, which is the first time this is needed for a Cluster (previously, only Instances combined these two Roles). Introduce this concept as a first-class property of a Cluster Engine, making it `false` by default, and make it `true` in MySQL version 8.0. Fixes #19735 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [x] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
In the newest version of the MySQL 8.0 Aurora engine, the S3 import and export Roles need to be combined, which is the first time this is needed for a Cluster (previously, only Instances combined these two Roles). Introduce this concept as a first-class property of a Cluster Engine, making it `false` by default, and make it `true` in MySQL version 8.0. Fixes aws#19735 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [x] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Describe the bug
Trying to Setup MySQL8 Aurora via CDK
CDK synth template has this
aurora_select_into_s3_role
is not a valid parameter for MySQL8 and deploy failsSee a similar issue reported here #19126, but probably this only resolved
import
and needs a similar fix forexport
Or is there a workaround?
Expected Behavior
aws_default_s3_role
for MySQL8 supports export as well and should be the parameter whens3BucketExport
is requested.Current Behavior
Reproduction Steps
Included in description
Possible Solution
No response
Additional Information/Context
No response
CDK CLI Version
2.19.0 (build e0d3e62)
Framework Version
No response
Node.js Version
v17.7.2
OS
Mac
Language
Typescript
Language Version
4.6.2
Other information
No response
The text was updated successfully, but these errors were encountered: