Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-ec2): L2 Transit Gateway #17528

Closed
1 of 2 tasks
NukaCody opened this issue Nov 16, 2021 · 2 comments · Fixed by #32956
Closed
1 of 2 tasks

(aws-ec2): L2 Transit Gateway #17528

NukaCody opened this issue Nov 16, 2021 · 2 comments · Fixed by #32956
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@NukaCody
Copy link

Description

L2 Construct for Transit Gateway

Use Case

Transit Gateways are used to build a centralize hub and spoke model, common in complex networking environments with multiple VPCs.

Proposed Solution

The code has been written for a side project, would love to contribute it upstream but wanted to make sure I'm not conflicting with anything: https://github.com/NukaCody/l2-transit-gateway

Other information

No response

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@NukaCody NukaCody added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 16, 2021
@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Nov 16, 2021
@njlynch
Copy link
Contributor

njlynch commented Dec 7, 2021

Hi @NukaCody !

Thanks for the idea and link to your construct library! To help us prioritize new L2s, we look for interest and engagement from the community (as well as internal metrics on how much usage the underlying L1s receive). I'm going to initially assign this as a p2, meaning we aren't able to work on this immediately.

We use 👍 s to help prioritize our work; you can reach out to the cdk.dev community on Slack to solicit support for prioritization.

Once we have a good number of people voting to prioritize this, we can dive in. The first step(s) would be to review the API via either an issue in our RFCs repo or as a PR against this issue with just the module's README, showing the API off and how a user would interact with it.

@njlynch njlynch added effort/medium Medium work item – several days of effort p2 and removed needs-triage This issue or PR still needs to be triaged. labels Dec 7, 2021
@njlynch njlynch removed their assignment Dec 7, 2021
paulhcsun added a commit that referenced this issue Feb 3, 2025
### Issue # (if applicable)

Closes #17528

### Description of changes

Create new Transit Gateway L2 with the following constructs:
 * `TransitGateway`
 * `TransitGatewayRouteTable`
 * `TransitGatewayRoute`
 * `TransitGatewayVpcAttachment`
 * `TransitGatewayRouteTableAssociation`
 * `TransitGatewayRouteTablePropagation`

#### Important Design Decision
As described in the README, the CDK disables the creation of the default
route table by EC2 and instead the CDK will create a "custom" default
route table in its place. This is primarily because there is no way to
obtain the route table ID of the EC2 created default route table without
a custom resource.

The CDK will disable the `defaultRouteTablePropagation` and
`defaultRouteTableAssociation` properties on the L1 (when both are
disabled, EC2 does not create the default route table), but the
properties are still exposed on the CDK TransitGateway interface to
allow it to be toggled for the CDK created default route table. The
automatic association/propagation is being mimicked by CDK
implementation and not relying on the actual EC2 feature.

### Describe any new or updated permissions being added

n/a


### Description of how you validated changes

Unit + Integration tests to verify that the deployed resources behave as
expected.

### Checklist
- [x] My code adheres to the [CONTRIBUTING
GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and
[DESIGN
GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license*

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Copy link

github-actions bot commented Feb 3, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants