(pipelines): additionalInputs fails for certain repository names

[bodokaiser]

It appears to me that the repository parameter used with CodePipelineSource.connection fails when used in additionalInputs of the CodePipeline props.

In our production setup, we get the following failure in the CodePipeline:

I tried reducing the problem to a minimal example and get a different error:

11 | [Container] 2021/07/25 11:54:01  INSTALL: 1 commands
12 | [Container] 2021/07/25 11:54:01  BUILD: 3 commands
13 | [Container] 2021/07/25 11:54:01 Phase complete: DOWNLOAD_SOURCE State: SUCCEEDED
14 | [Container] 2021/07/25 11:54:01 Phase context status code:  Message:
15 | [Container] 2021/07/25 11:54:01 Entering phase INSTALL
16 | [Container] 2021/07/25 11:54:01 Running command ln -s "$CODEBUILD_SRC_DIR_bodokaiser_cdk-pipeline-invalid-inputs_Source" "some_additional_input"
17 | ln: invalid option -- 'p'
18 | Try 'ln --help' for more information.

Reproduction Steps

Reproduction steps are summarized in the README.md of cdk-pipeline-invalid-inputs

What did you expect to happen?

A successful build.

What actually happened?

In our production environment CodePipeline raises an error that the input source name is invalid (containing dashes?) while in the minimal example the synth command fail.

Environment

• CDK CLI Version : 1.115.0
• Framework Version: 1.115.0
• Node.js Version: 16.5.0
• OS : macOS Big Sur
• Language (Version): Typescript (4.3.5)

---

This is 🐛 Bug Report

[ryparker]

Hey @bodokaiser 👋🏻

I wasn't able to reproduce this with the given code (replaced connection arn and repos).

Is that error throwing on the Source stage? Looking at the error I can see it starts with Error calling startBuild this seems like an error thrown by CodeBuild and not CodePipeline.

[bodokaiser]

@ryparker

The error is thrown in the Synth CodeBuild step right after the Source stage.

Do you repos contain dashes? My hypothesis is that it has something to do with dashes in the repository name which is either not formated correctly or too carefully validated.

In our production setup, the Synth CodeBuild step has the error:

editing the Synth CodeBuild step through the web interface reveals the following naming of the input artifacts:

I am not exactly sure how this relates to the error I encounter in the minimal repository cdk-pipeline-invalid-inputs. With that error:

it appears to me to be indeed related to the presence of dashes in the repository name as the -pipeline-invalid-inputs segment of cdk-pipeline-invalid-inputs is somewhat interpreted as command line argument -p"invalid-inputs or the like.

[bodokaiser]

@ryparker @rix0rrr is there anything else I can do for you to support you on this?

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.