[ec2] init file for windows returns empty

[abelmokadem]

I stumbled on this piece of code in CDK:

aws-cdk/packages/@aws-cdk/aws-ec2/lib/cfn-init-elements.ts

Lines 487 to 504 in 491113d

	protected _standardConfig(fileOptions: InitFileOptions, platform: InitPlatform, contentVars: Record<string, any>): Record<string, any> {
	if (platform === InitPlatform.WINDOWS) {
	if (fileOptions.group || fileOptions.owner || fileOptions.mode) {
	throw new Error('Owner, group, and mode options not supported for Windows.');
	}
	return {};
	}
	return {
	[this.fileName]: {
	...contentVars,
	mode: fileOptions.mode || '000644',
	owner: fileOptions.owner || 'root',
	group: fileOptions.group || 'root',
	},
	};
	}
	}

Why is line 492 returning an empty object and not the file? Windows CloudFormation init can also have files. Am I missing something or is this a bug?

Reproduction Steps

Create a Windows ec2 with the init option set and use ec2.InitFile.fromString.

What did you expect to happen?

I expected the CloudFormation init template to contain an entry with the file from the string I provided.

What actually happened?

The CloudFormation init template was empty for the files section: files: {}

I'm missing the files 😢

Environment

• CLI Version : 1.62.0
• Framework Version: 1.62.0
• Node.js Version: 14.7.0
• OS : OS X
• Language (Version): TypeScript

Other

---

This is 🐛 Bug Report

[abelmokadem]

I have "forked" some of the code into my repo and it's working with the following code:

    if (platform === InitPlatform.WINDOWS) {
      if (fileOptions.group || fileOptions.owner || fileOptions.mode) {
        throw new Error("Owner, group, and mode options not supported for Windows.");
      }
      return {
        [this.fileName]: {
          ...contentVars,
        },
      };
    }

    return {
      [this.fileName]: {
        ...contentVars,
        mode: fileOptions.mode || "000644",
        owner: fileOptions.owner || "root",
        group: fileOptions.group || "root",
      },
    };