Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aws-ec2] Add Latest AMD HPC Class C6G to InstanceClass ENUM #10372

Closed
2 tasks
JLosinski opened this issue Sep 15, 2020 · 2 comments · Fixed by #10558
Closed
2 tasks

[aws-ec2] Add Latest AMD HPC Class C6G to InstanceClass ENUM #10372

JLosinski opened this issue Sep 15, 2020 · 2 comments · Fixed by #10558
Assignees
@rix0rrr
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md in-progress This issue is being actively worked on. p2

Comments

@JLosinski
Copy link

InstanceType.of(InstanceClass) ENUM does not support C6G family. https://github.com/aws/aws-cdk/blob/master/packages/%40aws-cdk/aws-ec2/lib/instance-types.ts.

Use Case

Utilizing ENUM as best practice rather than string literal to define EC2 instance type in CDK stack.

Proposed Solution

Add C6G to ENUM - InstanceClass.COMPUTE6_GRAVITRON

COMPUTE6_GRAVITRON = 'c6g',

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@JLosinski JLosinski added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 15, 2020
@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Sep 15, 2020
@rix0rrr rix0rrr added effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md p2 labels Sep 16, 2020
@rrhodes
Copy link
Contributor

rrhodes commented Sep 26, 2020

Hello, I'm looking into this request now and should have a PR open shortly.

This was referenced Sep 26, 2020
Closed
Closed
Merged
@rrhodes
Copy link
Contributor

rrhodes commented Sep 26, 2020

After some minor complications - still learning the ropes - there's a PR open for review on this issue. :)

@SomayaB SomayaB added in-progress This issue is being actively worked on. and removed needs-triage This issue or PR still needs to be triaged. labels Sep 29, 2020
@mergify mergify bot closed this as completed in #10558 Sep 30, 2020
mergify bot pushed a commit that referenced this issue Sep 30, 2020
@rrhodes
feat(ec2): c6 graviton2 instance classes (#10558)
0d4d44f 
Adding support for [EC2 C6g](https://aws.amazon.com/ec2/instance-types/c6/) instance classes.

Closes #10372
---

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rix0rrr rix0rrr

Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md in-progress This issue is being actively worked on. p2
Projects
None yet
Milestone
No milestone
4 participants
@rix0rrr @rrhodes @SomayaB @JLosinski