update compare log test to use sdkv3 and remove aws-sdk dependency fr…

…om custom-resource-handlers Signed-off-by: Francis <[email protected]>
aws · Apr 15, 2024 · 4c4204c · 4c4204c
1 parent 7103fed
commit 4c4204c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/packages/@aws-cdk/custom-resource-handlers/package.json b/packages/@aws-cdk/custom-resource-handlers/package.json
@@ -63,8 +63,7 @@
     "@aws-sdk/client-synthetics": "3.421.0",
     "@aws-sdk/client-ecr": "3.421.0",
     "@aws-sdk/client-s3": "3.421.0",
-    "@aws-sdk/client-cloudwatch": "3.421.0",
-    "aws-sdk": "^2.1596.0"
+    "@aws-sdk/client-cloudwatch": "3.421.0"
   },
   "repository": {
     "url": "https://github.com/aws/aws-cdk.git",

diff --git a/packages/@aws-cdk/custom-resource-handlers/test/aws-eks/compare-log.test.ts b/packages/@aws-cdk/custom-resource-handlers/test/aws-eks/compare-log.test.ts
@@ -1,5 +1,5 @@
 /* eslint-disable import/no-extraneous-dependencies */
-import * as aws from 'aws-sdk';
+import { CreateClusterRequest, LogType } from '@aws-sdk/client-eks';
 import { compareLoggingProps } from '../../lib/aws-eks/cluster-resource-handler/compareLogging';
 
 /**
@@ -30,8 +30,8 @@ enum ClusterLoggingTypes {
 
 describe('compareLoggingProps', () => {
 
-  type Props = Partial<aws.EKS.CreateClusterRequest>;
-  const oldEnabledTypes: aws.EKS.LogTypes = [ClusterLoggingTypes.API, ClusterLoggingTypes.AUDIT];
+  type Props = Partial<CreateClusterRequest>;
+  const oldEnabledTypes: LogType[] = [ClusterLoggingTypes.API, ClusterLoggingTypes.AUDIT];
 
   test('when newProps.logging.clusterLogging is undefined, should disable all types with enabled:true in oldProps', () => {
     const oldProps: Props = {