BYOM Notebooks - Verbosity and other notes. #28
Conversation
| }, | ||
| "outputs": [], | ||
| "source": [ | ||
| "role = '<your SageMaker execution role here>'" |
There was a problem hiding this comment.
Can we update this to:
assumed_role = boto3.client('sts').get_caller_identity()['Arn']
role = re.sub(r'^(.+)sts::(\d+):assumed-role/(.+?)/.*$', r'\1iam::\2:role/\3', assumed_role)There was a problem hiding this comment.
I setup the conda_mxnet_py36 and conda_tf_py36 for both, I am not sure why that is not reflected here. Let me change and push again.
| @@ -182,11 +279,16 @@ | |||
| }, | |||
| "outputs": [], | |||
| "source": [ | |||
| "import sagemaker\n", | |||
| "\n", | |||
| "sagemaker.Session().delete_endpoint(predictor.endpoint)" | |||
There was a problem hiding this comment.
We may want to comment this out just so users don't hit "Run All" and then delete their endpoint before they've gotten a chance to experiment with it.
| @@ -19,13 +46,24 @@ | |||
| }, | |||
| "outputs": [], | |||
| "source": [ | |||
| "role = <<Your_Sagemaker_Role>>" | |||
| "role = '<your SageMaker execution role here>'" | |||
There was a problem hiding this comment.
Can we update this to:
assumed_role = boto3.client('sts').get_caller_identity()['Arn']
role = re.sub(r'^(.+)sts::(\d+):assumed-role/(.+?)/.*$', r'\1iam::\2:role/\3', assumed_role)Will also need to update metadata slightly then.
| "shutil.rmtree('export')" | ||
| "shutil.rmtree('export')\n", | ||
| "\n", | ||
| "sagemaker.Session().delete_endpoint(predictor.endpoint)" |
There was a problem hiding this comment.
We may want to comment this about, just to prevent users from hitting "Run All Cells" and accidentally deleting the endpoint before they've gotten a chance to experiment with it.
| "role = <<Your_Sagemaker_Role>>" | ||
| "role = '<your SageMaker execution role here>'" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
Will want to add metadata to this cell of: "isConfigCell": true
| "source": [ | ||
| "role = '<your SageMaker execution role here>'" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
Will want to add metadata to this cell of: "isConfigCell": true
|
All comments are accounted for, although there seems to be a potential new bug in the predict feeding pipeline to the SDK. |
Increased verbosity on all the notebooks so that there is a bit more detail on everything. Followed protocols in the checklist. Structured similar in style to other notebooks.