Migrate to Dep #317

SoManyHs · 2017-09-08T00:13:19Z

make build succeeds

samuelkarp · 2017-09-08T00:20:05Z

It looks like you now have vendor and ecs-cli/vendor. I think you should keep the dependencies under ecs-cli/vendor instead of in the root.

samuelkarp · 2017-09-08T00:25:40Z

github.com/hashicorp/go-cleanhttp seems to have disappeared. Do we no longer need it?
You have both github.com/Sirupsen/logrus and github.com/sirupsen/logrus. This is going to be bad for anyone with a case-insensitive filesystem. I think they also technically count as different imports in Go, which isn't great either.
golang.org/x/crypto looks like a new dependency.

SoManyHs · 2017-09-19T00:39:43Z

@samuelkarp, hmm, the logrus thing might be related to docker/libcompose#493.

rifelpet · 2017-09-19T13:40:42Z

Yeah, we have a project of our own that depends on docker/libcompose as well as docker/docker and docker/cli, and we're blocked on moving to dep until they update their dependencies.

Although with this merged it may help but I havent tried yet. You may want to try updating your dep to the latest master and trying the migration again.

SoManyHs · 2018-01-12T05:53:21Z

@rifelpet Out of curiosity, have you tried migrating to dep again recently? The case-sensitivity issue with logrus appears to have been fixed -- I'm in the process of trying this migration process again and it appears to be working with the latest version of dep, though it required a lot of manual dependency resolution on my end.

rifelpet · 2018-01-12T17:08:05Z

@SoManyHs I did see it was fixed but have not had the chance to try migrating again recently

SoManyHs · 2018-01-16T19:58:53Z

Rebased on top of #412.

aaithal · 2018-01-16T20:34:29Z

what's left here for making this go from [wip] to not be wip anymore?

aaithal · 2018-01-22T23:11:21Z

This seems like a spurious folder: https://github.com/SoManyHs/amazon-ecs-cli/tree/dep/ecs-cli/_vendor-20180112100655. Was that added by mistake? Or, is that required? If required, why is it required?

SoManyHs · 2018-01-22T23:18:19Z

@aaithal Oops, I thought I'd added that to the .gitignore but must have messed up. Should be fixed now--thanks for the catch!

aaithal · 2018-01-22T23:20:19Z

Can you also confirm if you need any changes to the scripts/license.sh file (because the vendor dir might have around a bit)?

SoManyHs · 2018-01-22T23:22:50Z

@aaithal Yep, already on it.

adnxn

@SoManyHs i think we should explicitly constrain the dependencies to specific branch, version or revision in the Gopkg.toml file.

Updated major dependencies (libcompose, golang.org/x/*, docker, Azure/go-ansiterm), largely to get rid of case-sensitive dependency collision of Sirupsen.

PettitWesley · 2018-02-09T22:09:53Z

ecs-cli/Gopkg.toml

@@ -0,0 +1,66 @@
+
+# Gopkg.toml example


Should this example code be removed?

i think the examples here are useful since there are a few ways to constrain your dependencies.

PettitWesley · 2018-02-09T22:10:38Z

ecs-cli/Gopkg.toml

+
+
+[[constraint]]
+  name = "github.com/aws/aws-sdk-go"


Per @adnxn's comment, can you lock all of the dependencies on a specific version or githash, etc?

- From ecs-cli dir, ran `dep init` - Removed Godeps dir - Ran `make generate` (to update licenses)

Ran `dep ensure && dep prune` to get rid of unused vendor files added by `dep init` (dep v0.3.2)

- Updated Gopkg.toml manually (NOTE: Using the "revision" constraint is not usually recommended, but it was the easiest to do for the moment and would ensure consistency with what was previously in the Godeps manifest) - Ran dep ensure && dep prune (dep v0.3.2)

SoManyHs · 2018-02-13T07:04:35Z

Okay, updated.

scripts.sh seems like it should still work since the vendor dir hasn't changed location (@aaithal)
Revisions added to the manifest -- typically locking to a revision isn't recommended, but it's the easiest to do for now and keeps it most consistent with what we were using with Godep. (@adnxn, @PettitWesley)
This also supersedes Update dependencies to use lowercase sirupsen #412

aaithal

lgtm

adnxn · 2018-02-13T23:46:49Z

we can close this now #282

SoManyHs · 2018-02-13T23:50:04Z

Good catch. I'll close it when we next release.

SoManyHs force-pushed the dep branch from b8b9c5a to 48ac1d3 Compare September 11, 2017 19:42

SoManyHs mentioned this pull request Sep 12, 2017

Switch from godep to dep #282

Closed

SoManyHs force-pushed the dep branch 2 times, most recently from 0d31395 to ec85c18 Compare October 17, 2017 00:10

SoManyHs force-pushed the dep branch 2 times, most recently from d4e25ab to b7fe70d Compare October 30, 2017 19:53

SoManyHs force-pushed the dep branch 2 times, most recently from 145f9c2 to d7adfeb Compare November 9, 2017 23:17

SoManyHs force-pushed the dep branch from d7adfeb to 5ee2de2 Compare November 15, 2017 09:30

SoManyHs force-pushed the dep branch from 5ee2de2 to a62717a Compare January 12, 2018 06:14

SoManyHs changed the base branch from master to dev January 12, 2018 06:18

SoManyHs mentioned this pull request Jan 12, 2018

Update dependencies to use lowercase sirupsen #412

Closed

SoManyHs force-pushed the dep branch from a62717a to d053e76 Compare January 12, 2018 18:12

SoManyHs requested review from aaithal, samuelkarp and PettitWesley January 16, 2018 19:57

SoManyHs requested a review from adnxn January 16, 2018 20:01

SoManyHs force-pushed the dep branch 2 times, most recently from f90f3c5 to 814156d Compare January 22, 2018 22:51

SoManyHs force-pushed the dep branch from 814156d to 9d0eaee Compare January 22, 2018 23:17

SoManyHs force-pushed the dep branch 3 times, most recently from 0491dae to 8d2f800 Compare January 29, 2018 23:20

adnxn reviewed Feb 1, 2018

View reviewed changes

Update dependencies

671db2f

Updated major dependencies (libcompose, golang.org/x/*, docker, Azure/go-ansiterm), largely to get rid of case-sensitive dependency collision of Sirupsen.

SoManyHs changed the title ~~[WIP] Migrate to Dep~~ Migrate to Dep Feb 6, 2018

SoManyHs force-pushed the dep branch 2 times, most recently from fd7c7cc to 97dcef4 Compare February 7, 2018 00:38

PettitWesley reviewed Feb 9, 2018

View reviewed changes

SoManyHs added 3 commits February 12, 2018 22:56

Migrate to dep

3a8c7f7

- From ecs-cli dir, ran `dep init` - Removed Godeps dir - Ran `make generate` (to update licenses)

Add vendor files from migration to dep

c4ab8e4

Ran `dep ensure && dep prune` to get rid of unused vendor files added by `dep init` (dep v0.3.2)

SoManyHs force-pushed the dep branch from 97dcef4 to 6cb45c6 Compare February 13, 2018 06:59

SoManyHs force-pushed the dep branch 2 times, most recently from e40e223 to 402889b Compare February 13, 2018 07:07

Update Contributing doc

402889b

aaithal approved these changes Feb 13, 2018

View reviewed changes

PettitWesley approved these changes Feb 13, 2018

View reviewed changes

adnxn approved these changes Feb 13, 2018

View reviewed changes

SoManyHs merged commit 402889b into aws:dev Feb 13, 2018

SoManyHs deleted the dep branch February 13, 2018 21:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate to Dep #317

Migrate to Dep #317

SoManyHs commented Sep 8, 2017 •

edited

Loading

samuelkarp commented Sep 8, 2017

samuelkarp commented Sep 8, 2017

SoManyHs commented Sep 19, 2017

rifelpet commented Sep 19, 2017

SoManyHs commented Jan 12, 2018

rifelpet commented Jan 12, 2018

SoManyHs commented Jan 16, 2018

aaithal commented Jan 16, 2018

aaithal commented Jan 22, 2018 •

edited

Loading

SoManyHs commented Jan 22, 2018

aaithal commented Jan 22, 2018

SoManyHs commented Jan 22, 2018

adnxn left a comment

PettitWesley Feb 9, 2018

adnxn Feb 9, 2018

PettitWesley Feb 9, 2018

SoManyHs commented Feb 13, 2018

aaithal left a comment

adnxn commented Feb 13, 2018

SoManyHs commented Feb 13, 2018

Migrate to Dep #317

Migrate to Dep #317

Conversation

SoManyHs commented Sep 8, 2017 • edited Loading

samuelkarp commented Sep 8, 2017

samuelkarp commented Sep 8, 2017

SoManyHs commented Sep 19, 2017

rifelpet commented Sep 19, 2017

SoManyHs commented Jan 12, 2018

rifelpet commented Jan 12, 2018

SoManyHs commented Jan 16, 2018

aaithal commented Jan 16, 2018

aaithal commented Jan 22, 2018 • edited Loading

SoManyHs commented Jan 22, 2018

aaithal commented Jan 22, 2018

SoManyHs commented Jan 22, 2018

adnxn left a comment

Choose a reason for hiding this comment

PettitWesley Feb 9, 2018

Choose a reason for hiding this comment

adnxn Feb 9, 2018

Choose a reason for hiding this comment

PettitWesley Feb 9, 2018

Choose a reason for hiding this comment

SoManyHs commented Feb 13, 2018

aaithal left a comment

Choose a reason for hiding this comment

adnxn commented Feb 13, 2018

SoManyHs commented Feb 13, 2018

SoManyHs commented Sep 8, 2017 •

edited

Loading

aaithal commented Jan 22, 2018 •

edited

Loading