Fix to not log entire background processor options #3033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziyiz-amzn
force-pushed
the
fix-bg-processor
branch
from
cd81b27 to
f3a0d5b
Compare
xuesichao
approved these changes
Jan 29, 2025
hensmi-amazon
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
optionsincludes a logger attribute, stringify() can be memory heavy in main thread if a it's a POSTLogger or MultiLogger.Description of changes: Only log valuable options
Testing:
Private build tested by QA.
Can these tested using a demo application? Please provide reproducible step-by-step instructions.
Yes, pack js sdk and get it installed in react component, test the react demo.
Checklist:
Have you successfully run
npm run build:releaselocally?Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?
Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.