Use default framerate when video track framerate is undefined in `Def…

…aultVideoFrameProcessorPipeline` (#3045) Co-authored-by: Shi Su <[email protected]>
aws · Feb 26, 2025 · a1079c5 · a1079c5
1 parent c81e938
commit a1079c5
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,9 +12,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Removed
 
 ### Changed
+- Use default framerate when video track framerate is undefined in `DefaultVideoFrameProcessorPipeline`
 
 ### Fixed
-Fix TypeError when calling unbindVideoElement
+- Fix TypeError when calling unbindVideoElement
 
 ## [3.27.0] - 2024-12-11
 

diff --git a/src/videoframeprocessor/DefaultVideoFrameProcessorPipeline.ts b/src/videoframeprocessor/DefaultVideoFrameProcessorPipeline.ts
@@ -73,7 +73,7 @@ export default class DefaultVideoFrameProcessorPipeline implements VideoFramePro
   // A negative framerate will cause `captureStream` to throw `NotSupportedError`.
   // The setter prevents this by switching to the default framerate if less than 0.
   set framerate(value: number) {
-    this.fr = value < 0 ? DEFAULT_FRAMERATE : value;
+    this.fr = value < 0 || value === undefined ? DEFAULT_FRAMERATE : value;
   }
 
   stop(): void {

diff --git a/test/videoframeprocessor/DefaultVideoFrameProcessorPipeline.test.ts b/test/videoframeprocessor/DefaultVideoFrameProcessorPipeline.test.ts
@@ -318,6 +318,11 @@ describe('DefaultVideoFrameProcessorPipeline', () => {
       pipe.framerate = -5;
       expect(pipe.framerate).to.equal(15);
     });
+
+    it('setter ignores undefined frame rate', () => {
+      pipe.framerate = undefined;
+      expect(pipe.framerate).to.equal(15);
+    });
   });
 
   describe('addObserver', () => {