Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename remaining MIE references in strings #729

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

colinazn
Copy link
Member

Description of changes:

Rename remaining "Media Insights Engine" strings to "Media Insights on
AWS" and "MIE" to "Media Insights" or "MI" based on the string
containing it.

Also fixed some echo lines in the build-s3-dist.sh script that were
using environment variables that were never initialized.

@colinazn colinazn requested a review from dch90 February 17, 2023 18:11
Background
==========

The solution was renamed from Media Insights Engine to Media
Insights on AWS. We renamed most references and links but a few
still remained in strings.

Change
======

Rename remaining "Media Insights Engine" strings to "Media Insights on
AWS" based on the string
containing it.

Also fixed some `echo` lines in the build-s3-dist.sh script that were
using environment variables that were never initialized.

Testing
=======

* Build and deploy.
* Ran unit, integration, and end-to-end tests.
@dch90 dch90 force-pushed the rename-remaining-mie branch from f63cfef to 01b215f Compare February 17, 2023 22:19
@dch90 dch90 removed their request for review February 17, 2023 22:25
@colinazn colinazn requested a review from dch90 February 17, 2023 23:13
@dch90 dch90 merged commit b003442 into feature/v5.1.0 Feb 17, 2023
@dch90 dch90 deleted the rename-remaining-mie branch February 17, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants