Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print which SSM parameter was not found #68

Closed

Conversation

xmik
Copy link

@xmik xmik commented Jul 8, 2021

Without this PR

When we have the following resource in the manifest.yaml:

- name: SomeIAMRole
  resource_file: templates/some-iam-role.template
  parameters:
    - parameter_key: "param1"
      parameter_value: "$[alfred_ssm_/my/path/to/param1]"
    - parameter_key: "param2"
      parameter_value: "$[alfred_ssm_/my/path/to/param2]"

and a SSM parameter does not exist, we get the following error:

An error occurred (ParameterNotFound) when calling the GetParameter operation:

And in result, we don't know which SSM Parameter is not found.

With this PR

The error would be:

The following SSM Parameter was not found:  /my/path/to/param2
An error occurred (ParameterNotFound) when calling the GetParameter operation:

This will make troubleshooting easier.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Without this commit, we get a general error: ParameterNotFound and we
don't know which SSM parameter it concerns
@groverlalit
Copy link
Member

Thanks creating the pull request. We have added this to our backlog.

@aijunpeng
Copy link
Member

This issued has been fixed.

@aijunpeng aijunpeng closed this Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants