Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generating regional STS endpoints to allow for default EBS encryption in opt-in regions #284

Merged
merged 6 commits into from
Feb 4, 2025

Conversation

boueya
Copy link
Contributor

@boueya boueya commented Jan 24, 2025

… so that we can build a regional STS endpoint.

Fixes #222

Global STS Client endpoints will not work for new (opt-in) regions.
Updated the logic under the ec2_default_ebs_encryption to generate regional endpoints so that STS can properly apply default EBS encryption in opt-in regions.


By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license].

Apache 2.0 License

@IevIe IevIe self-requested a review February 3, 2025 16:31
Copy link
Contributor

@IevIe IevIe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. Passed all scanners. Approved.

@IevIe IevIe merged commit 3897038 into aws-samples:main Feb 4, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Enabling EBS Default Encryption in a non default region fails
2 participants