Fix support for neural-only voices (#160)

* Fix semantic version comparison logic * Fix support for neural-only voices
aws-samples · Mar 1, 2023 · 688a15b · 688a15b
1 parent 9812a62
commit 688a15b
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 4 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/amazon-sumerian-hosts-core/package.json b/packages/amazon-sumerian-hosts-core/package.json
@@ -20,5 +20,8 @@
   "scripts": {
     "lint": "eslint .",
     "docs": "jsdoc -c jsdoc.conf.json"
+  },
+  "dependencies": {
+    "compare-versions": "^6.0.0-rc.1"
   }
 }
diff --git a/packages/amazon-sumerian-hosts-core/src/core/awspack/AbstractTextToSpeechFeature.js b/packages/amazon-sumerian-hosts-core/src/core/awspack/AbstractTextToSpeechFeature.js
@@ -1,5 +1,6 @@
 // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
 // SPDX-License-Identifier: MIT-0
+import {compareVersions} from 'compare-versions';
 import AbstractHostFeature from '../AbstractHostFeature';
 import AnimationUtils from '../animpack/AnimationUtils';
 import MathUtils from '../MathUtils';
@@ -278,7 +279,7 @@ class AbstractTextToSpeechFeature extends AbstractHostFeature {
         response.Voices.forEach(voice => {
           if (
             voice.SupportedEngines.includes('standard') ||
-            version >= minNeuralSdk
+            compareVersions(version, minNeuralSdk) >= 0
           ) {
             availableVoices.push(voice);
           }
@@ -370,7 +371,10 @@ class AbstractTextToSpeechFeature extends AbstractHostFeature {
     // Default to the standard engine if neural is not available for this version
     if (
       engine === undefined ||
-      this.constructor.AWS_VERSION < this.constructor.POLLY_MIN_NEURAL_VERSION
+      compareVersions(
+        this.constructor.AWS_VERSION,
+        this.constructor.POLLY_MIN_NEURAL_VERSION
+      ) < 0
     ) {
       engine = this.constructor.POLLY_DEFAULTS.Engine;
     }