Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): Added functions to confirm user and get user attributes #151

Merged
merged 6 commits into from
Feb 29, 2024

Conversation

fahadsadiq
Copy link
Contributor

Description of changes:
Added function to confirm sign up and get user attributes.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ottokruse
Copy link
Contributor

Thanks!

Q: why have access token be a param, and not depend solely on await retrieveTokens()? More efficient if you have the access token at hand already? (Practically, retrieveTokens() will be near instant)

@ottokruse
Copy link
Contributor

To fix prettier issues, run this in the root of the workspace:

npx prettier -w .

@fahadsadiq
Copy link
Contributor Author

The reason is that we are using this lib server side on svelte. We wanted to use cookies and it became a bit difficult to set and get those cookies.

So we wanted to pass the token as a param instead.

@ottokruse
Copy link
Contributor

Got it, understood, and thanks for the explanation.

Cool to hear you use this in Svelte on server side! Let us know any feedback you have to make life easier for that (such as more docs maybe ...)

See prettier is still failing. Make sure you have the exact same version as the lib? Should be 3.1.1

@ottokruse ottokruse merged commit 7fa7b0b into aws-samples:main Feb 29, 2024
1 check passed
@ottokruse
Copy link
Contributor

THANKS!

@ottokruse
Copy link
Contributor

Published to NPM in v0.13.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants