-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error documentation #135
Conversation
Include a building option to avoid "Dynamic require of \"stream\" is not supported" error.
Thanks! Please run prettier and reformat the code and we're good |
Still prettier is complaining. Can you run it like this from the root of the workspace?: |
Sorry mate it's getting worse! The issue must be that you use another prettier config than the project. I see now that there is no prettier config in the project (which surprises me, didn't notice before), and I am not sure what is going on now ... looks like on your machine prettier finds another config file that you have. Try this instead: We could add prettier config to this project to prevent this. Maybe add an empty prettier key in package.json (empty so we get all defaults): |
No problem. Added. I believe you already merged the code. |
Still trailing comma's were added to many files, not 100% sure why, maybe because you use prettier V3 (this repo is pinned at 2.8.4). Reverted that myself and pushed to your branch. |
All done now. Thanks for your vigilance on our docs! |
Issue #, if available:
n/a.
Description of changes:
Include a building option to avoid "Dynamic require of "stream" is not supported" error.