Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug that required fido2 config object to be passed for Config #129

Merged
merged 1 commit into from
Dec 11, 2023
Merged

fix bug that required fido2 config object to be passed for Config #129

merged 1 commit into from
Dec 11, 2023

Conversation

brno32
Copy link
Contributor

@brno32 brno32 commented Dec 10, 2023 •
edited
Loading

resolves #128

I feel if fido2 isn't defined, determineFido can just return "NO". Perhaps there are downstream effects I'm not aware of but seems simplest to me

@ottokruse
Copy link
Contributor

Seems reasonable and simple enough :)

@ottokruse ottokruse merged commit ca2609a into aws-samples:main Dec 11, 2023
@ottokruse
Copy link
Contributor

ottokruse commented Dec 11, 2023 •
edited
Loading

Released in https://github.com/aws-samples/amazon-cognito-passwordless-auth/releases/tag/v0.12.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ottokruse ottokruse ottokruse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: Missing Fido2 config when not providing fido2 object to Config
2 participants
@brno32 @ottokruse