Add AllowedApplicationOrigin environment variable for non url origins #127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: N/A
Description of changes:
Adds a new environment variable and logic for handling origins that are not proper URLs (such as those used by Android apps).
The reason for this change is due to android apps sending
android:apk-key-hash:some_hash
instead of a URL. Currently the origin passed by the client is converted to a URL object which will fail with non-url origins. This behaviour is explained in the webauthn spec hereThis PR aims to avoid changing the current behaviour with allowedOrigins and adds this as an extra feature.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.