feat(SecretProviderClass): add support for objectAlias #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-bigelow
requested review from
aws-ia-ci,
parkand1,
shapirov103,
youngjeong46,
elamaran11 and
a team
as code owners
|
Per our conversation @shapirov103 |
shapirov103
reviewed
Mar 1, 2024
There was a problem hiding this comment.
@a-bigelow great work, please see just a few comments.
You mentioned that this support handles cases when non-json structures are used as secrets. Please add a paragraph on this usage to the docs/addons/secrets-store.md - I am sure customers will be looking for it.
shapirov103
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Closes #939
Description of changes:
Adds support for the
objectAliasparameter via thesecretAlias?input. This input lives next tosecretNameand allows for the name of the kubernetes secret to differ from the name of the AWS Secret or SSM Parameter it is sourced from.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.