Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/broken monorepo pipelines. support monorepo style with blueprints pipelines #936

Merged
merged 8 commits into from
Feb 28, 2024

Conversation

shapirov103
Copy link
Collaborator

Issue #, if available: #913

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@shapirov103 shapirov103 marked this pull request as ready for review February 27, 2024 05:13
@shapirov103
Copy link
Collaborator Author

@elamaran11 please take a look when you get a chance. this adds support for mono repo.

you can test it by running the example code:

cd examples/monorepo
npx cdk deploy pipeline

Copy link
Collaborator

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shapirov103 Approach looks good, some minor comments.

examples/monorepo/lib/pipeline.ts Outdated Show resolved Hide resolved
examples/monorepo/lib/pipeline.ts Outdated Show resolved Hide resolved
docs/pipelines.md Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@shapirov103 shapirov103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed code review comments

docs/pipelines.md Outdated Show resolved Hide resolved
examples/monorepo/lib/pipeline.ts Outdated Show resolved Hide resolved
examples/monorepo/lib/pipeline.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Running the test at my end.

@elamaran11
Copy link
Collaborator

@shapirov103 Pipeline fails on local run

Do you wish to deploy these changes (y/n)? y
pipeline: deploying... [1/1]
pipeline: creating CloudFormation changeset...
7:14:14 AM | CREATE_FAILED        | AWS::CodePipeline::Webhook  | blueprintsekspipel...okResourceF5706C6B
Webhook could not be registered with GitHub. Error cause: Not found [StatusCode: 404, Body: {"message":"Not Found","documentation_url":"https://docs.github.com/rest/repos/webhook
s#create-a-repository-webhook"}] (Service: AWSCodePipeline; Status Code: 400; Error Code: ValidationException; Request ID: 7caec739-835d-4710-a965-ab5dd718b872; Proxy: null)

@elamaran11
Copy link
Collaborator

@shapirov103 The stack ran fine now.

@shapirov103 shapirov103 merged commit 1cbb3c7 into main Feb 28, 2024
2 checks passed
@shapirov103 shapirov103 deleted the bug/broken-monorepo-pipelines branch February 28, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants