docfix: add-on URL links #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngjeong46
requested review from
aws-ia-ci,
parkand1,
shapirov103,
elamaran11 and
a team
as code owners
shapirov103
reviewed
Dec 6, 2023
There was a problem hiding this comment.
@youngjeong46 looks great - surely better than before.
Since we are on that topic can you also fix the ack reference that fails in the GH action on this PR:
FILE: docs/addons/ack-addon.md
[✖] https://eksworkshop-v2-next.netlify.app/docs/gitops/controlplanes/ack/configureResources
[✖] https://eksworkshop-v2-next.netlify.app/docs/gitops/controlplanes/ack/
should be replaced with
https://www.eksworkshop.com/docs/automation/controlplanes/ack/provision-resources
I see no other failures. You can also run make markdown-link-check locally to check before submitting.
youngjeong46
changed the title
|
@shapirov103 - done, this should be good to merge pending end-to-end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Fixing broken links in the Karpenter and ACK add-on documentations.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.