Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kubevious AddOn] Correct kubevious service type setpath #861

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

vumdao
Copy link
Contributor

@vumdao vumdao commented Oct 22, 2023

Issue #, if available:

Description of changes:
From kubevious helm Doc, current setpath of UI service type kubevious.service.type is not correct

Test:

  • AddOn
AddOns.push(new KubeviousAddOn({
      version: '1.2.1',
      kubeviousServiceType: 'NodePort',
    }));
  • Deploy
➜  ~ k get svc -n kubevious
NAME                            TYPE        CLUSTER-IP       EXTERNAL-IP   PORT(S)        AGE
kubevious-backend-clusterip     ClusterIP   172.20.230.157   <none>        4000/TCP       28h
kubevious-collector-clusterip   ClusterIP   172.20.22.28     <none>        4000/TCP       28h
kubevious-guard-clusterip       ClusterIP   172.20.181.25    <none>        4000/TCP       28h
kubevious-mysql                 ClusterIP   172.20.169.242   <none>        3306/TCP       28h
kubevious-parser-clusterip      ClusterIP   172.20.119.231   <none>        4000/TCP       28h
kubevious-redis                 ClusterIP   172.20.161.139   <none>        6379/TCP       28h
kubevious-ui-nodeport           NodePort    172.20.34.122    <none>        80:30737/TCP   15m

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Collaborator

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @shapirov103 Please review and run e2e.

@shapirov103 shapirov103 merged commit 69d730e into aws-quickstart:main Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants