Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Konveyor Addon #840

Merged
merged 7 commits into from
Oct 23, 2023
Merged

Konveyor Addon #840

merged 7 commits into from
Oct 23, 2023

Conversation

ariveroi
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Collaborator

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ariveroi Similar comments to Patterns repo but also have more :

  1. Since this looks like partner product, Please have partner commenting on the repo for ongoing maintenance.
  2. Please share license keys for validation.
  3. Documentation needs to be updated per comments for completeness.
  4. The addon is not added to addon list documentation here.
  5. Please review our partner extensions guide once.

docs/addons/konveyor.md Outdated Show resolved Hide resolved
docs/addons/konveyor.md Show resolved Hide resolved
docs/addons/konveyor.md Show resolved Hide resolved
docs/addons/konveyor.md Show resolved Hide resolved
docs/addons/konveyor.md Show resolved Hide resolved
@cbellone
Copy link

hello @elamaran11

This is Celestino Bellone, I am an employee of Claranet Switzerland, and I am one of the maintainers of https://github.com/claranet-ch/konveyor-eks-blueprint-addon .

As requested, this is to confirm that Claranet will support the ongoing maintenance of the Konveyor EKS Addon.

Let me know if you need anything else from our side.

Thanks,
Celestino

@elamaran11
Copy link
Collaborator

hello @elamaran11

This is Celestino Bellone, I am an employee of Claranet Switzerland, and I am one of the maintainers of https://github.com/claranet-ch/konveyor-eks-blueprint-addon .

As requested, this is to confirm that Claranet will support the ongoing maintenance of the Konveyor EKS Addon.

Let me know if you need anything else from our side.

Thanks, Celestino

Thankyou @cbellone Appreciate your notes on the PR. This is enough for us to proceed with further review. We will work with @ariveroi to help him work on the comments and get this merged asap.

Copy link
Collaborator

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ariveroi Nice work. Update to index.md doc file is missing. Rest looks good atm.

freschri
freschri previously approved these changes Oct 13, 2023
Copy link
Collaborator

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ariveroi Have a question

docs/addons/index.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@elamaran11 elamaran11 merged commit 9582a82 into aws-quickstart:main Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants