-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Konveyor Addon #840
Konveyor Addon #840
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ariveroi Similar comments to Patterns repo but also have more :
- Since this looks like partner product, Please have partner commenting on the repo for ongoing maintenance.
- Please share license keys for validation.
- Documentation needs to be updated per comments for completeness.
- The addon is not added to addon list documentation here.
- Please review our partner extensions guide once.
hello @elamaran11 This is Celestino Bellone, I am an employee of Claranet Switzerland, and I am one of the maintainers of https://github.com/claranet-ch/konveyor-eks-blueprint-addon . As requested, this is to confirm that Claranet will support the ongoing maintenance of the Konveyor EKS Addon. Let me know if you need anything else from our side. Thanks, |
Thankyou @cbellone Appreciate your notes on the PR. This is enough for us to proceed with further review. We will work with @ariveroi to help him work on the comments and get this merged asap. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ariveroi Nice work. Update to index.md
doc file is missing. Rest looks good atm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ariveroi Have a question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.