Fixing GH Actions #827

elamaran11 · 2023-08-21T20:18:09Z

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

shapirov103

Please see my comment. I am a bit unclear on how to test this since we already released, so I really don't want to run another release. I can manually invoke the action, but unsure if it has any dependency on the event data.

.github/workflows/docbuild.yml

elamaran11 · 2023-08-21T20:31:46Z

Please see my comment. I am a bit unclear on how to test this since we already released, so I really don't want to run another release. I can manually invoke the action, but unsure if it has any dependency on the event data.

You can test it by adding your branch on Push like i did it with the PR. If you push a commit to this PR, it will test it.

.github/workflows/docbuild.yml

shapirov103

A couple of comments

shapirov103 · 2023-08-22T20:38:29Z

lib/builders/observability-builder.ts

@@ -1,24 +1,26 @@
-import * as blueprints from '../../lib';
+import * as blueprintbuilder from '../../lib/stacks';


let's replace with import { BlueprintBuilder } from ... and just use it as BlueprintBuilder

shapirov103 · 2023-08-22T20:38:50Z

lib/builders/observability-builder.ts

 import * as utils from "../utils";
+import * as spi from '../../lib/spi'


make lint - I see GH actions missing semicolons and such

elamaran11 · 2023-08-22T20:45:22Z

A couple of comments

@shapirov103 All comments fixed, pls check

shapirov103 · 2023-08-22T20:59:54Z

/do-e2e-tests

aws-ia-ci

end to end tests failed. A maintainer can provide more details.

shapirov103

LGTM

shapirov103 · 2023-08-22T22:42:51Z

/do-e2e-tests

aws-ia-ci

end to end tests failed. A maintainer can provide more details.

shapirov103 · 2023-08-23T17:34:37Z

@elamaran11 can you confirm that local test provisioning and destroying the cluster was successful?

elamaran11 · 2023-08-23T17:46:57Z

@elamaran11 can you confirm that local test provisioning and destroying the cluster was successful?

@shapirov103 Yes both actions are successful in my local test.

 ✅  blueprint-construct-dev

✨  Deployment time: 2154.68s

Outputs:
blueprint-construct-dev.EfsFileSystemId = fs-034f445d4bbfbbc26
blueprint-construct-dev.KarpenterInstanceNodeRole = blueprint-construct-dev-blueprintconstructdevkarpe-1WVREF8469K2D
blueprint-construct-dev.KarpenterInstanceProfilename = KarpenterNodeInstanceProfile-5f2c240d3e6b1c6adb774710b3c1100b
blueprint-construct-dev.batchJobvirtualclusterid = 1cevkdo5lh4ce9xf7h17gtf91
blueprint-construct-dev.blueprintconstructdevClusterName582E8C46 = blueprint-construct-dev
blueprint-construct-dev.blueprintconstructdevConfigCommand197026E2 = aws eks update-kubeconfig --name blueprint-construct-dev --region us-east-2 --role-arn arn:aws:iam::940019131157:role/blueprint-construct-dev-AdminRole38563C57-R5U46QZ6DFL6
blueprint-construct-dev.blueprintconstructdevGetTokenCommand4F1D3C87 = aws eks get-token --cluster-name blueprint-construct-dev --region us-east-2 --role-arn arn:aws:iam::940019131157:role/blueprint-construct-dev-AdminRole38563C57-R5U46QZ6DFL6
blueprint-construct-dev.burnhamsa = burnham-sa
blueprint-construct-dev.burnhamsasecretproviderclass = burnham-aws-secrets
blueprint-construct-dev.platformteamadmin = arn:aws:iam::940019131157:role/Admin
blueprint-construct-dev.rikersa = riker-sa
blueprint-construct-dev.teamtroisaiamrole = arn:aws:iam::940019131157:role/blueprint-construct-dev-blueprintconstructdevinfba-18FHRNOFZGVTJ
Stack ARN:
arn:aws:cloudformation:us-east-2:940019131157:stack/blueprint-construct-dev/574f1910-41bd-11ee-ba45-0a38b43ebe9d

✨  Total time: 2163.07s


❯
cdk destroy "*" --require-approval never --no-rollback
zsh: correct 'cdk' to 'cd' [nyae]? n
zsh: command not found: cdk
❯
npx cdk destroy "*" --require-approval never --no-rollback
INFO Chart aws-load-balancer-controller-1.6.0 is at the latest version.
INFO Chart appmesh-controller-1.12.2 is at the latest version.
INFO Chart cert-manager-1.12.3 is at the latest version.
INFO Chart kube-state-metrics-5.10.1 is at the latest version.
INFO Chart prometheus-node-exporter-4.22.0 is at the latest version.
DEBUG Core add-on adot is at version v0.78.0-eksbuild.1
INFO Chart base-1.18.2 is at the latest version.
INFO Chart istiod-1.18.2 is at the latest version.
INFO Chart tigera-operator-v3.26.1 is at the latest version.
INFO Chart metrics-server-3.11.0 is at the latest version.
WARN Upgrade is needed for chart argo-cd-5.43.4: latest version is 5.43.5.
INFO Chart nginx-ingress-0.18.1 is at the latest version.
WARN Upgrade is needed for chart velero-3.2.0: latest version is 5.0.2.
DEBUG Core add-on vpc-cni is at version v1.13.4-eksbuild.1
DEBUG Core add-on coredns is at version v1.10.1-eksbuild.2
DEBUG Core add-on kube-proxy is at version auto
INFO Chart gatekeeper-3.13.0 is at the latest version.
No versions are found for karpenter in repository oci://public.ecr.aws/karpenter/karpenter
INFO Chart aws-node-termination-handler-0.21.0 is at the latest version.
INFO Chart kubevious-1.2.1 is at the latest version.
DEBUG Core add-on aws-ebs-csi-driver is at version v1.21.0-eksbuild.1
INFO Chart aws-efs-csi-driver-2.4.9 is at the latest version.
INFO Chart keda-2.11.2 is at the latest version.
INFO Chart aws-privateca-issuer-1.2.5 is at the latest version.
INFO Chart flux2-2.9.2 is at the latest version.
No versions are found for oci://ghcr.io/grafana-operator/helm-charts/grafana-operator in repository undefined
INFO Chart aws-for-fluent-bit-0.1.28 is at the latest version.
INFO Chart airflow-1.10.0 is at the latest version.
INFO Chart external-secrets-0.9.3 is at the latest version.
INFO Chart external-dns-1.13.0 is at the latest version.
INFO Chart secrets-store-csi-driver-1.3.4 is at the latest version.
DEBUG Core add-on kube-proxy has autoselected version v1.27.1-eksbuild.1
Are you sure you want to delete: blueprint-construct-dev (y/n)? y
blueprint-construct-dev: destroying... [1/1]

 ✅  blueprint-construct-dev: destroyed

The failure is specific to the e2e test account, happens only on delete and cannot be reproduced locally. Tests against other accounts succeeded.

Fixing GH Actions

4d4ce82

elamaran11 requested review from aws-ia-ci, parkand1, shapirov103, youngjeong46 and a team as code owners August 21, 2023 20:18

Fixing GH Actions

e4bece4

shapirov103 reviewed Aug 21, 2023

View reviewed changes

.github/workflows/docbuild.yml Show resolved Hide resolved

elamaran11 added 2 commits August 21, 2023 16:25

Fixing GH Actions

9781163

Fixing GH Actions

fa1251e

elamaran11 added 3 commits August 22, 2023 13:50

Adding Builder Class Inde

0a5940b

Adding Builder Class Index

4614289

Adding Builder Class Index

e438ce6

shapirov103 reviewed Aug 22, 2023

View reviewed changes

.github/workflows/docbuild.yml Outdated Show resolved Hide resolved

Adding Builder Class Index

1f2ea44

shapirov103 reviewed Aug 22, 2023

View reviewed changes

Adding Builder Class Index

f9fa97f

aws-ia-ci requested changes Aug 22, 2023

View reviewed changes

shapirov103 approved these changes Aug 22, 2023

View reviewed changes

shapirov103 requested a review from aws-ia-ci August 22, 2023 22:42

aws-ia-ci previously requested changes Aug 22, 2023

View reviewed changes

shapirov103 approved these changes Aug 23, 2023

View reviewed changes

shapirov103 merged commit e42d0ed into main Aug 23, 2023

shapirov103 deleted the fix/ghActions branch August 23, 2023 18:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixing GH Actions #827

Fixing GH Actions #827

elamaran11 commented Aug 21, 2023

shapirov103 left a comment

elamaran11 commented Aug 21, 2023

shapirov103 left a comment

shapirov103 Aug 22, 2023

elamaran11 Aug 22, 2023

shapirov103 Aug 22, 2023

elamaran11 Aug 22, 2023

elamaran11 commented Aug 22, 2023

shapirov103 commented Aug 22, 2023

aws-ia-ci left a comment

shapirov103 left a comment

shapirov103 commented Aug 22, 2023

aws-ia-ci left a comment

shapirov103 commented Aug 23, 2023

elamaran11 commented Aug 23, 2023 •

edited

Loading

		@@ -1,24 +1,26 @@
		import * as blueprints from '../../lib';
		import * as blueprintbuilder from '../../lib/stacks';

		import * as utils from "../utils";
		import * as spi from '../../lib/spi'

Fixing GH Actions #827

Fixing GH Actions #827

Conversation

elamaran11 commented Aug 21, 2023

shapirov103 left a comment

Choose a reason for hiding this comment

elamaran11 commented Aug 21, 2023

shapirov103 left a comment

Choose a reason for hiding this comment

shapirov103 Aug 22, 2023

Choose a reason for hiding this comment

elamaran11 Aug 22, 2023

Choose a reason for hiding this comment

shapirov103 Aug 22, 2023

Choose a reason for hiding this comment

elamaran11 Aug 22, 2023

Choose a reason for hiding this comment

elamaran11 commented Aug 22, 2023

shapirov103 commented Aug 22, 2023

aws-ia-ci left a comment

Choose a reason for hiding this comment

shapirov103 left a comment

Choose a reason for hiding this comment

shapirov103 commented Aug 22, 2023

aws-ia-ci left a comment

Choose a reason for hiding this comment

shapirov103 commented Aug 23, 2023

elamaran11 commented Aug 23, 2023 • edited Loading

elamaran11 commented Aug 23, 2023 •

edited

Loading