Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Observability Builder for Observability Accelerator #804

Merged
merged 9 commits into from
Aug 8, 2023
Merged

Observability Builder for Observability Accelerator #804

merged 9 commits into from
Aug 8, 2023

Conversation

elamaran11
Copy link
Collaborator

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

shapirov103
shapirov103 reviewed Aug 2, 2023
View reviewed changes
Copy link
Collaborator

@shapirov103 shapirov103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments

lib/builders/observability-builder.ts Show resolved Hide resolved
docs/builders/observability-builder.md Show resolved Hide resolved
shapirov103
shapirov103 reviewed Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@shapirov103 shapirov103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elamaran11 moving in the right direction. Added a few comments.
Please update the public method for native/mixed/oss with a small js doc to describe what you mean. the method names require intimate knowledge of our thinking process and will be confusing to the customers without explanation.

lib/builders/observability-builder.ts Outdated Show resolved Hide resolved
lib/builders/observability-builder.ts Outdated Show resolved Hide resolved
lib/builders/observability-builder.ts Outdated Show resolved Hide resolved
lib/builders/observability-builder.ts Outdated Show resolved Hide resolved
@elamaran11
Copy link
Collaborator Author

@elamaran11 moving in the right direction. Added a few comments. Please update the public method for native/mixed/oss with a small js doc to describe what you mean. the method names require intimate knowledge of our thinking process and will be confusing to the customers without explanation.

@shapirov103 All comments are mixed, Please review and merge.

shapirov103
shapirov103 reviewed Aug 4, 2023
View reviewed changes
Copy link
Collaborator

@shapirov103 shapirov103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see a couple of places that were missed once method names were refactored.

docs/builders/observability-builder.md Outdated Show resolved Hide resolved
docs/builders/observability-builder.md Outdated Show resolved Hide resolved
@elamaran11
Copy link
Collaborator Author

Please see a couple of places that were missed once method names were refactored.

Nice catch, issues are fixed.

shapirov103
shapirov103 approved these changes Aug 8, 2023
View reviewed changes
Copy link
Collaborator

@shapirov103 shapirov103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shapirov103 shapirov103 merged commit 5e95e09 into main Aug 8, 2023
@shapirov103 shapirov103 deleted the feature/observabilityBuilder branch August 8, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shapirov103 shapirov103 shapirov103 approved these changes

@aws-ia-ci aws-ia-ci Awaiting requested review from aws-ia-ci aws-ia-ci is a code owner

@parkand1 parkand1 Awaiting requested review from parkand1

@youngjeong46 youngjeong46 Awaiting requested review from youngjeong46 youngjeong46 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elamaran11 @shapirov103