fix(addons/karpenter): merge user provided settings.aws values with addon provided values.
#803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… overrides Signed-off-by: Braden Mars <[email protected]>
…rovided values Signed-off-by: Braden Mars <[email protected]>
BradenM
requested review from
aws-ia-ci,
parkand1,
shapirov103,
youngjeong46,
elamaran11 and
a team
as code owners
shapirov103
approved these changes
Aug 2, 2023
There was a problem hiding this comment.
@BradenM Looks great, thank you for your contribution.
@youngjeong46 please take a look as well.
I will kick off e2e test.
|
/do-e2e-tests |
aws-ia-ci
requested changes
Aug 2, 2023
|
@shapirov103 Interesting. Am I able to view logs of the e2e tests anywhere? |
|
@BradenM there was a failure from the previous run, which failed to deprovision the stack. So subsequent runs failed. Now it is addressed, I will rerun. |
|
/do-e2e-tests |
youngjeong46
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Closes #802
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.